Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Incorrect sourcemaps in dev #1700

Closed
1 of 12 tasks
zardoy opened this issue Jan 28, 2022 · 2 comments
Closed
1 of 12 tasks

[Bug]: Incorrect sourcemaps in dev #1700

zardoy opened this issue Jan 28, 2022 · 2 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@zardoy
Copy link

zardoy commented Jan 28, 2022

Which Remix packages are impacted?

  • remix (Remix core)
  • create-remix
  • @remix-run/architect
  • @remix-run/cloudflare-workers
  • @remix-run/dev
  • @remix-run/express
  • @remix-run/netlify
  • @remix-run/node
  • @remix-run/react
  • @remix-run/serve
  • @remix-run/server-runtime
  • @remix-run/vercel

What version of Remix are you using?

1.1.3

What version of Node are you using? Minimum supported version is 14.

16.13.0

Steps to Reproduce

  1. Scaffold an app from create-remix
  2. Create a loader in app/routes/index.ts:
export const loader = () => {
    // debugger
    return [] // set breakpoint here via IDE
}
  1. (in case of vscode): Run Debug: JavaScript Debug Terminal (extension.js-debug.createDebuggerTerminal), run npm run dev in it
  2. Open the page

Expected Behavior

  • The code will stop the execution in case if debugger is uncommented
  • Breakpoint won't bound and I think this might happen because of incorrect paths to source files in sourcemaps. I also suppose stacktrace on errors should show real files paths

Actual Behavior

The code should stop the execution on breakpoints from IDE

@zardoy zardoy added the bug Something isn't working label Jan 28, 2022
@zardoy
Copy link
Author

zardoy commented Jan 28, 2022

Probably #367 already got it covered.

@machour
Copy link
Collaborator

machour commented Mar 18, 2022

Yes, closing in favor of #367

@machour machour closed this as completed Mar 18, 2022
@MichaelDeBoey MichaelDeBoey added the duplicate This issue or pull request already exists label Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants