Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Layout route with more than one pathless layout causes invalid conflict #3327

Closed
pokedotdev opened this issue May 29, 2022 · 7 comments · Fixed by #4421
Closed

[Bug]: Layout route with more than one pathless layout causes invalid conflict #3327

pokedotdev opened this issue May 29, 2022 · 7 comments · Fixed by #4421
Labels
bug Something isn't working feat:routing

Comments

@pokedotdev
Copy link

pokedotdev commented May 29, 2022

What version of Remix are you using?

1.5.1

Steps to Reproduce

Create a route structure like so:

app/routes
├── slug
│  ├── __bar
│  │  └── bar.tsx
│  ├── __foo
│  │  ├── foo.tsx
│  │  └── index.tsx
│  ├── __bar.tsx
│  └── __foo.tsx
└── slug.tsx

Expected Behavior

Layout routes can have more than one pathless layout route.

Actual Behavior

The error is thrown when starting remix:

Error: Path "slug/" defined by route "routes/slug/__foo" conflicts with route "routes/slug/__bar"

You can see reproduction here

@pokedotdev pokedotdev changed the title Dynamic route with pathless layouts routes causes conflicts [Bug]: Dynamic route with pathless layouts routes causes conflicts May 29, 2022
@pokedotdev pokedotdev changed the title [Bug]: Dynamic route with pathless layouts routes causes conflicts [Bug]: Layout route with more than one pathless layout causes invalid conflict May 29, 2022
@machour machour linked a pull request May 30, 2022 that will close this issue
2 tasks
@pokedotdev pokedotdev reopened this Jun 8, 2022
@goldo
Copy link

goldo commented Jun 10, 2022

Hi, I can confirm this, I have the same problem. (I wouldn't flag it as "feat" tho, it looks like a bug to me)

@binajmen
Copy link
Contributor

binajmen commented Jan 10, 2023

I have the same problem with ^1.9.0. @machour, should you flag it as bug instead?

@machour machour added bug Something isn't working and removed bug:unverified labels Jan 10, 2023
@machour
Copy link
Collaborator

machour commented Jan 24, 2023

Will be fixed by #4421

@brophdawg11
Copy link
Contributor

#4421 is merged and should be available once v1.17.0 is released

@brophdawg11 brophdawg11 added the awaiting release This issue has been fixed and will be released soon label May 24, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-33cc4c0-20230525 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

🤖 Hello there,

We just published version 1.17.0-pre.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

🤖 Hello there,

We just published version 1.17.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@brophdawg11 brophdawg11 removed the awaiting release This issue has been fixed and will be released soon label Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feat:routing
Projects
None yet
5 participants