Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private GitHub stack templates don't work with the releases/latest/download/{filename} url structure #4328

Closed
johnmberger opened this issue Oct 5, 2022 · 2 comments · Fixed by #4329

Comments

@johnmberger
Copy link
Contributor

johnmberger commented Oct 5, 2022

What version of Remix are you using?

1.7.2

Steps to Reproduce

Instantiate a stack using a template from a private GitHub repo, an access token, and the "latest" release url:

npx create-remix@latest ./my-new-project --template https://github.com/owner/repo/releases/latest/download/stack.tar.gz --token myaccesstoken

Expected Behavior

Since the https://github.com/owner/repo/releases/latest/download/stack.tar.gz url should always link to the latest release tag, I would expect the stack validation to work successfully and the remix project to initialize successfully.

Actual Behavior

The command fails with the following error: 🚨 The template file could not be verified. Please double check the URL and try again.

However, if you do know the latest release tag, manually include it, and try again:

npx create-remix@latest ./my-new-project --template https://github.com/owner/repo/releases/download/v.1.1/stack.tar.gz --token myaccesstoken

Then it works just fine.

I suspect this is because there's a quirk in the Github URL structure between the latest tag and a specified version (releases/latest/download vs. releases/download/version) and the Remix code isn't handling the former.

My org maintains a private Github monorepo that includes a stack tarball and it would be great to allow users to link directly to the latest release instead of having to know the exact version number.

@machour
Copy link
Collaborator

machour commented Oct 12, 2022

Thank you @johnmberger!

@machour machour closed this as completed Oct 12, 2022
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-eebaa56-20221013 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants