Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remix build hangs after build when no tty is available. #5021

Closed
tiagoad opened this issue Jan 6, 2023 · 9 comments
Closed

remix build hangs after build when no tty is available. #5021

tiagoad opened this issue Jan 6, 2023 · 9 comments

Comments

@tiagoad
Copy link

tiagoad commented Jan 6, 2023

What version of Remix are you using?

1.9.0

Steps to Reproduce

Add a package.json script build that runs remix build, and another that runs npm-run-all -l build.

Expected Behavior

Build finishes as usual.

Actual Behavior

Build hangs after Built in 2.3s.

@tiagoad
Copy link
Author

tiagoad commented Jan 6, 2023

As a workaround, I changed the build script to script -qefc \"script -q /dev/null remix build\"

@cdeath
Copy link

cdeath commented Jan 7, 2023

remix build > /dev/null 2>&1 also works

@TrySound
Copy link
Contributor

Reproducible with turborepo and pnpm run -r

@TrySound
Copy link
Contributor

Remix build started to hang since https://github.com/remix-run/remix/releases/tag/remix%401.7.5. Probably in #4410

cc @pcattori

@TrySound
Copy link
Contributor

TrySound commented Feb 23, 2023

Reproduced with pnpm run --parallel --filter=@webstudio-is/builder build

Found this incremental flag make build hang. With incremental: false all works.

@TrySound
Copy link
Contributor

@pcattori New esbuild version seems moved away from incremental flag so upgrade may solve the issue.

@pcattori
Copy link
Contributor

pcattori commented May 2, 2023

Remix v1.16 shipped with more changes to compiler including upgrading to esbuild 0.17.6 and removing the incremental flag in favor of rebuilds via esbuild context. Can anyone here try things out with latest and see if this is still an issue?

@pcattori
Copy link
Contributor

pcattori commented Jul 3, 2023

Tested on 1.18.1. Original issue seems to be resolved.

package.json scripts:

{
  "scripts": {
    "stuff": "npm-run-all -l build",
    "build": "remix build",
  }
}

Running npm run stuff finishes without hanging:

Screenshot 2023-07-03 at 1 36 00 PM

@pcattori
Copy link
Contributor

pcattori commented Jul 3, 2023

@TrySound like I mentioned earlier, we've upgraded to esbuild 17 and are now using esbuild context (instead of incremental option) for incremental builds.

If issue reemerges, feel free to reopen.

@pcattori pcattori closed this as completed Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants