Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unstable_vanillaExtract does not update via HMR when using unstable_dev #5642

Closed
1 task done
drewschrauf opened this issue Mar 3, 2023 · 2 comments
Closed
1 task done
Assignees

Comments

@drewschrauf
Copy link

What version of Remix are you using?

1.14.0

Are all your remix dependencies & dev-dependencies using the same version?

  • Yes

Steps to Reproduce

We're already using unstable_dev and unstable_vanillaExtract for our project. When we attempted to upgrade to Remix v1.14.0, we found the new HMR behaviour applies to React components but not to CSS generated through Vanilla Extract. I don't know if this applies to @remix-run/css-bundle in general or is specific to Vanilla Extract.

I've created a minimal reproduction.

  1. Start the app with npm run dev
  2. Edit the text in app/routes/index.tsx from Hello to Goodbye
  3. Note that the text updates without refreshing the browser
  4. Edit the style in app/routes/index.css.ts from blue to red
  5. Note that the color does not update

Log messages are visible in the browser window. The app has seen the .css.ts file has changed but it doesn't apply the update.

Expected Behavior

New styles should apply without a browser refresh.

Actual Behavior

New styles do not apply until a browser refresh.

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-4d86674-20230321 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@markdalgleish
Copy link
Member

Thanks for raising this issue. The fix should be out in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants