Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remix 1.16.0-pre.0 fails to run for CF-Pages. esbuild css-file plugin error #6196

Closed
1 task done
tobiasfoerg opened this issue Apr 26, 2023 · 2 comments · Fixed by #6238
Closed
1 task done

Remix 1.16.0-pre.0 fails to run for CF-Pages. esbuild css-file plugin error #6196

tobiasfoerg opened this issue Apr 26, 2023 · 2 comments · Fixed by #6238
Assignees
Labels

Comments

@tobiasfoerg
Copy link

tobiasfoerg commented Apr 26, 2023

What version of Remix are you using?

1.16.0-pre.0

Are all your remix dependencies & dev-dependencies using the same version?

  • Yes

Steps to Reproduce

checkout reproduction repo
or create run pnpm create-remix@1.16.0-pre.0 select cf pages template.
add a css file and load in root.
start the dev server: pnpm dev.

Expected Behavior

should start the dev server

Actual Behavior

Building Remix app in production mode...
✘ [ERROR] Build failed with 1 error:
node_modules/.pnpm/esbuild-plugin-polyfill-node@0.2.0_esbuild@0.17.6/node_modules/esbuild-plugin-polyfill-node/polyfills/process.js:1:25: ERROR: Could not resolve "process" [plugin css-file]

    app/root.tsx:10:19:
      10 │ import styles from "./test.css";
         ╵                    ~~~~~~~~~~~~

  This error came from the "onLoad" callback registered here:

    node_modules/.pnpm/@remix-run+dev@1.16.0-pre.0/node_modules/@remix-run/dev/dist/compiler/plugins/cssImports.js:66:12:
      66 │       build.onLoad({
         ╵             ~~~~~~

    at setup (/Users/tobias/github/tobiasfoerg/cf-pages-remix-css-bug/node_modules/.pnpm/@remix-run+dev@1.16.0-pre.0/node_modules/@remix-run/dev/dist/compiler/plugins/cssImports.js:66:13)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async handlePlugins (/Users/tobias/github/tobiasfoerg/cf-pages-remix-css-bug/node_modules/.pnpm/esbuild@0.17.6/node_modules/esbuild/lib/main.js:1326:9)
@tobiasfoerg tobiasfoerg changed the title Remix 1.16.0-pre.0 new Dev-Server fails to run for CF-Pages. esbuild css-file plugin error Remix 1.16.0-pre.0 fails to run for CF-Pages. esbuild css-file plugin error Apr 26, 2023
@markdalgleish
Copy link
Member

@MichaelDeBoey This seems related to the migration to esbuild-plugin-polyfill-node in #5274. Any ideas?

@jacob-ebey jacob-ebey added bug Something isn't working and removed bug:unverified labels Apr 28, 2023
@machour machour linked a pull request Apr 29, 2023 that will close this issue
2 tasks
@MichaelDeBoey
Copy link
Member

Closed by #6238, which will be available in the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants