Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: drop React 17 support #7121

Merged
merged 1 commit into from
Aug 15, 2023
Merged

feat!: drop React 17 support #7121

merged 1 commit into from
Aug 15, 2023

Conversation

MichaelDeBoey
Copy link
Member

@pcattori & @ryanflorence mentioned in #7021 that we would do this

@changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 8612ac7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Major
@remix-run/eslint-config Major
@remix-run/react Major
@remix-run/testing Major
create-remix Major
remix Major
@remix-run/architect Major
@remix-run/cloudflare Major
@remix-run/cloudflare-pages Major
@remix-run/cloudflare-workers Major
@remix-run/css-bundle Major
@remix-run/deno Major
@remix-run/express Major
@remix-run/node Major
@remix-run/serve Major
@remix-run/server-runtime Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MichaelDeBoey MichaelDeBoey added BREAKING CHANGE This change will require a major version bump v2 Issues related to v2 apis labels Aug 10, 2023
@MichaelDeBoey MichaelDeBoey force-pushed the drop-react-17-support branch from e3a2486 to 7d09db8 Compare August 10, 2023 00:28
@MichaelDeBoey MichaelDeBoey changed the title feat!: drop React v17 support feat!: drop React 17 support Aug 10, 2023
@brophdawg11
Copy link
Contributor

In order to support optional entry files and npx remix reveal - we had some logic in @remix-run/dev that detects the react version and uses/outputs react 17/18-compatible versions of entry.server/entry.client. I removed all of that in 399f697 now that everything is react 18 + streaming.

@MichaelDeBoey MichaelDeBoey force-pushed the drop-react-17-support branch 4 times, most recently from c35305a to 95dde05 Compare August 15, 2023 21:12
@MichaelDeBoey @brophdawg11
feat!: drop React 17 support
8612ac7 
Co-authored-by: Matt Brophy <matt@brophy.org>
@MichaelDeBoey MichaelDeBoey force-pushed the drop-react-17-support branch from 95dde05 to 8612ac7 Compare August 15, 2023 22:22
@MichaelDeBoey MichaelDeBoey merged commit da2d9fb into remix-run:dev Aug 15, 2023
@MichaelDeBoey MichaelDeBoey deleted the drop-react-17-support branch August 15, 2023 22:53
@MichaelDeBoey MichaelDeBoey mentioned this pull request Aug 16, 2023
Merged
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-96b05af-20230816 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot mentioned this pull request Aug 28, 2023
Merged
@KarelVerschraegen KarelVerschraegen mentioned this pull request Sep 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brophdawg11 brophdawg11 brophdawg11 left review comments

@pcattori pcattori pcattori approved these changes

@ryanflorence ryanflorence Awaiting requested review from ryanflorence

@markdalgleish markdalgleish Awaiting requested review from markdalgleish

@jacob-ebey jacob-ebey Awaiting requested review from jacob-ebey

Assignees
No one assigned
Labels
BREAKING CHANGE This change will require a major version bump CLA Signed docs package:eslint-config package:testing renderer:react template:architect template:cloudflare-pages template:cloudflare-workers template:express template:fly template:remix v2 Issues related to v2 apis
Projects
No open projects
v2
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelDeBoey @brophdawg11 @pcattori