Skip to content

Commit 783fe05

Browse files
committed
Update test to reflect charset-normalizer updates
We don't pin charset-normalizer versions, so this test is likely to flake as changes are made to that library. - charset-normalizer 3.3.0 reports this encoding as CP949. - charset-normalizer 3.3.1 and 3.3.1 report it as Big5. Perhaps we don't care what the value is here. Should we remove this test? Or, perhaps change it to assert that the encoding is not utf-8?
1 parent c3afb13 commit 783fe05

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tests/test_utilities.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ def test_empty_df():
5454
[
5555
(b"abcde", "utf-8"), # straight up ascii is a subset of unicode
5656
(b"Eyjafjallaj\xc3\xb6kull", "utf-8"), # actual unicode
57-
(b"\xC4pple", "cp037"), # non-unicode, ISO characterset
57+
(b"\xC4pple", "Big5"), # non-unicode, ISO characterset
5858
],
5959
)
6060
def test_detect_encoding(test_string, encoding):

0 commit comments

Comments
 (0)