-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debug.js colour and logging behaviour changed with the upgrade to v2 #1638
debug.js colour and logging behaviour changed with the upgrade to v2 #1638
Comments
I think I know why this is, but can you provide a sample repo (reduced down as much as possible) so that I can replicate against? |
thank you for response, sorry don't have enough bandwidth for that 😥 |
Well, same here, but can you at least share some part of your code so that someone else has a chance of replicating what colour lib you're using? |
made a repro repo here: https://github.com/noway/debugjsnodemonbug debug.js colours stuff itself by the looks of it |
Same problem here, since 2.0.1 (not in 2.0.0). The problem is with the package |
const supportsColor = require('supports-color')
if (supportsColor.stdout) {
console.log('Terminal stdout supports color')
} else {
console.log('Terminal stdout DO NOT supports color')
}
if (supportsColor.stderr) {
console.log('Terminal stderr supports color')
} else {
console.log('Terminal stderr DO NOT supports color')
} With nodemon@2.0.0
With nodemon@2.0.1
|
Perfect replication info - thank you. Will pick up, I know the change that's triggered this issue. |
I've been able to get a fix for this, but I need to write a test to show it happening and show it's fixed (so it doesn't reoccur). |
Waiting on nodemon@2.0.2 - going up now |
nodemon -v
: 2.0.1node -v
:v12.6.0Expected behaviour
Actual behaviour
Steps to reproduce
use debug.js on v1 and v2. on v1 logging suffixes and colour shown on all lines, on v2 logging suffixes shown only on first colour with no colour.
If applicable, please append the
--dump
flag on your command and include the output here ensuring to remove any sensitive/personal details or tokens.The text was updated successfully, but these errors were encountered: