Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JMH support #120

Closed
farquet opened this issue May 7, 2019 · 7 comments
Closed

JMH support #120

farquet opened this issue May 7, 2019 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@farquet
Copy link
Collaborator

farquet commented May 7, 2019

The suite should provide support for OpenJDK JMH.

@ceresek
Copy link
Collaborator

ceresek commented May 7, 2019

Could you please elaborate what such support would look like ? Making the runIteration method into something that JMH executes in a separate JVM instance and then collect the results, or ... ?

@axel22
Copy link
Member

axel22 commented May 7, 2019

I think that we should have a separate build target in build.sbt that knows how to bundle a JMH-compliant JAR. There is an sbt plugin that knows how to detect JMH wrapper classes and do that.

The only thing that our build.sbt task should be capable of doing is generating those JMH wrappers (so that they call proper lifecycle methods, like setUpBeforeAll of a Renaissance benchmark), immediately before the "package JAR" step.

@plokhotnyuk
Copy link

@axel22 could it be done with sbt-jmh?

@axel22
Copy link
Member

axel22 commented May 7, 2019

@axel22 could it be done with sbt-jmh?

Yes, exactly - that's the one I was referring to! I think it should work quite well.

@farquet farquet added the enhancement New feature or request label May 8, 2019
@axel22
Copy link
Member

axel22 commented Jun 14, 2019

@lbulej @vhotspur
I plan to dedicate some time into implementing this.
My plan is to add an additional subproject that is capable of producing a JMH jar. I don't think this should conflict with the API redesign (#81), but still wanted to give you a heads-up first!

@axel22 axel22 self-assigned this Jun 14, 2019
@lbulej
Copy link
Member

lbulej commented Jun 14, 2019

Fine with me, let's see how that goes.

@axel22
Copy link
Member

axel22 commented Jun 15, 2019

Closed with: #154

@axel22 axel22 closed this as completed Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants