Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conflict in travis php versions and applied unit tests #14

Open
goatherd opened this issue Jul 25, 2014 · 2 comments
Open

conflict in travis php versions and applied unit tests #14

goatherd opened this issue Jul 25, 2014 · 2 comments
Assignees

Comments

@goatherd
Copy link

as support for multiple PHP versions was added unit tests will fail if the test assumption is not matched.

In especially PHP 5.3 env will not report function names deprecated since 5.5 by default.

@goatherd goatherd added the bug label Jul 25, 2014
@goatherd goatherd self-assigned this Jul 25, 2014
@goatherd
Copy link
Author

@reneoelke @Ephigenia there are two options to fix this:

  • do only test compatibility up to the current PHP version
  • do always test anything and skip unsupported features (like trait keyword)

What would you expect a PHP 5.3 user to test against by default?
PHP 5.3 compat or newest PHP compat?
Is this the same setting we want to be covered by unit tests for that version?

It is still possible to set compat version range by cli argument.

@goatherd
Copy link
Author

@reneoelke according to our talk the test will get simplified and we concentrate on 5.5 support for now.

The functionality part is answered by #15. The remainder we may discuss later on.

@goatherd goatherd added enhancement and removed bug labels Jul 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant