Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting types wrong on new exercises #31

Closed
renlok opened this issue Feb 22, 2016 · 4 comments
Closed

Getting types wrong on new exercises #31

renlok opened this issue Feb 22, 2016 · 4 comments
Labels

Comments

@renlok
Copy link
Owner

renlok commented Feb 22, 2016

Only the first set of a new exercise should set its type all none unit sets should then default to that

@renlok renlok added the bug label Feb 22, 2016
@renlok
Copy link
Owner Author

renlok commented Feb 23, 2016

line 428 block add a $this->exercises[$i]['update'] flag that setExerciseDefaultTypes checks + in the block have new set to false (done want to continually update it)

@renlok
Copy link
Owner Author

renlok commented Feb 23, 2016

The ordering of types weight should be first so unless a unit is used all new exercises are assumed to be weight based

@renlok
Copy link
Owner Author

renlok commented Feb 23, 2016

Needs more testing maybe fixed in 00113a5

@renlok
Copy link
Owner Author

renlok commented Feb 24, 2016

pretty sure this is fixed now, can close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant