Unable to make Renovate to report new GitHub release assets

[kleini]

What would you like help with?

I would like help with my configuration

How are you running Renovate?

Self-hosted

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

container image 38.70.1 run with podman locally

Please tell us more about your question or problem

I wrote a customManager to find URLs of GitHub release assets in my code. I would like to upgrade those URLs now with Renovate utilizing the github-release-attachments datasource. I have one older version of adoptium/temurin8-binaries in my link and Renovate should now detect the new GitHub release and its assets but it does not.

The issue can be easily reproduced with the files in the following repository: https://github.com/kleini/renovate-reproduction
I run Renovate locally using the following command
podman run -it --rm --env-file=.env -v $(pwd):/usr/src/app docker.io/renovate/renovate:latest --dry-run --platform=local
The .env file only contains
LOG_LEVEL=debug
and a GitHub token.

Logs (if relevant)

Logs

DEBUG: Checking packageFiles for deprecated packages (repository=local)
       "packageFiles": {
         "regex": [
           {
             "deps": [
               {
                 "depName": "adoptium/temurin8-binaries",
                 "currentValue": "8u412b08",
                 "datasource": "github-release-attachments",
                 "replaceString": "OpenJDK8U-jdk_x64_linux_hotspot_8u412b08.tar.gz",
                 "updates": [],
                 "packageName": "adoptium/temurin8-binaries",
                 "versioning": "semver-coerced",
                 "warnings": [],
                 "sourceUrl": "https://github.com/adoptium/temurin8-binaries",
                 "registryUrl": "https://github.com",
                 "currentVersion": "8u412b08",
                 "currentVersionTimestamp": "2024-09-02T20:03:27.000Z",
                 "fixedVersion": "8u412b08"
               },
               {
                 "depName": "adoptium/temurin11-binaries",
                 "currentValue": "11.0.24_8",
                 "datasource": "github-release-attachments",
                 "replaceString": "OpenJDK11U-jdk_x64_linux_hotspot_11.0.24_8.tar.gz",
                 "updates": [],
                 "packageName": "adoptium/temurin11-binaries",
                 "versioning": "semver-coerced",
                 "warnings": [],
                 "sourceUrl": "https://github.com/adoptium/temurin11-binaries",
                 "registryUrl": "https://github.com",
                 "currentVersion": "11.0.24_8",
                 "currentVersionTimestamp": "2024-07-17T21:00:29.000Z",
                 "fixedVersion": "11.0.24_8"
               }
             ],
             "matchStrings": [
               "OpenJDK(?<major>[0-9]+)U-jdk_x64_linux_hotspot_(?<currentValue>[0-9a-z\\._]*)\\.tar\\.gz"
             ],
             "depNameTemplate": "adoptium/temurin{{{major}}}-binaries",
             "datasourceTemplate": "github-release-attachments",
             "packageFile": "Temurin.kt"
           }
         ]
       }

What is missing in the renovate.json to make Renovate look for the new 8u422b05 release and its assets?

Here is the minimal reproduction repo: https://github.com/kleini/renovate-reproduction/

[github-actions[bot]]

Hi there,

Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. Discussions without reproductions are less likely to be converted to Issues.

Please follow these steps:

1. Read our guide on creating a minimal reproduction.
2. Go to our minimal reproduction template repository.
3. Select the Use this template button to create a new repository based on the template.
4. Work on the minimal reproduction in your own repository.
5. Fill out the information in your repository's README.md.
6. Add the link to your reproduction to the first post of your Discussion. If you are not the original author, you can post a new comment with the link.

Good luck,

The Renovate team

[rarkins]

Please see our guide on "minimal" reproductions, namely your config

[kleini]

I provided now the link to a repository for reproduction in the first post of this discussion.

[rarkins]

It is not a minimal reproduction

[kleini]

Can you please recheck and if it still is not a minimal reproduction, can you please tell my why it is not one?

[rarkins]

The config is 30 lines long

[kleini]

Now renovate.json only contains the customManager configuration.

[rarkins]

From the reproduction repo you have this:

             "currentValue": "8u412b08",
             "datasource": "github-release-attachments",
             "replaceString": "OpenJDK8U-jdk_x64_linux_hotspot_8u412b08.tar.gz",
             "updates": [],
             "packageName": "adoptium/temurin8-binaries",
             "versioning": "semver-coerced",

That doesn't look like an appropriate value to use with semver-coerced versioning. That currentValue will be coerced to 8.0.0. You might need to use regex versioning to produce 8.412.08 if that's valid?

Meanwhile in the github repo you have releases like jdk8u422-b05.1 which is not the exact same pattern as you extracted.

[kleini]

Thank you very much so far for your help.
I extended the config now with a versioningTemplate and extractVersionTemplate. The debug output changed a bit, especially currentVersion and fixedVersion is not shown anymore.
Can you please provide another hint, what is missing now for Renovate after the versioning is fixed?

[rarkins]

What is the new packageFiles with updates log entry after these changes?

[kleini]

As shown in the current behavior:

DEBUG: packageFiles with updates (repository=local)
   "config": {
     "regex": [
       {
         "deps": [
           {
             "depName": "adoptium/temurin8-binaries",
             "currentValue": "8u412b08",
             "datasource": "github-release-attachments",
             "versioning": "regex:^(?<major>\\d+)[u\\.](?<minor>\\d+)[-b\\.]+(?<patch>\\d+)(?:[\\._]+(?<build>\\d))?$",
             "extractVersion": "regex:^(?<major>\\d+)[u\\.](?<minor>\\d+)[-b\\.]+(?<patch>\\d+)(?:[\\._]+(?<build>\\d))?$",
             "replaceString": "OpenJDK8U-jdk_x64_linux_hotspot_8u412b08.tar.gz",
             "updates": [],
             "packageName": "adoptium/temurin8-binaries",
             "warnings": [],
             "sourceUrl": "https://github.com/adoptium/temurin8-binaries",
             "registryUrl": "https://github.com"
           },
           {
             "depName": "adoptium/temurin11-binaries",
             "currentValue": "11.0.24_8",
             "datasource": "github-release-attachments",
             "versioning": "regex:^(?<major>\\d+)[u\\.](?<minor>\\d+)[-b\\.]+(?<patch>\\d+)(?:[\\._]+(?<build>\\d))?$",
             "extractVersion": "regex:^(?<major>\\d+)[u\\.](?<minor>\\d+)[-b\\.]+(?<patch>\\d+)(?:[\\._]+(?<build>\\d))?$",
             "replaceString": "OpenJDK11U-jdk_x64_linux_hotspot_11.0.24_8.tar.gz",
             "updates": [],
             "packageName": "adoptium/temurin11-binaries",
             "warnings": [],
             "sourceUrl": "https://github.com/adoptium/temurin11-binaries",
             "registryUrl": "https://github.com"
           }
         ],
         "matchStrings": [
           "OpenJDK(?<major>[0-9]+)U-jdk_x64_linux_hotspot_(?<currentValue>[0-9a-z\\._]*)\\.tar\\.gz"
         ],
         "depNameTemplate": "adoptium/temurin{{{major}}}-binaries",
         "datasourceTemplate": "github-release-attachments",
         "versioningTemplate": "regex:^(?<major>\\d+)[u\\.](?<minor>\\d+)[-b\\.]+(?<patch>\\d+)(?:[\\._]+(?<build>\\d))?$",
         "extractVersionTemplate": "regex:^(?<major>\\d+)[u\\.](?<minor>\\d+)[-b\\.]+(?<patch>\\d+)(?:[\\._]+(?<build>\\d))?$",
         "packageFile": "Temurin.kt"
       }
     ]
   }

I updated the README.md together with the version regex.

[rarkins]

When validating your regex versioning on regex101.com I see this, which is good:

But when I look at https://github.com/adoptium/temurin8-binaries/releases those strings don't match that.

I see you tried to do something with extractVersion but I'm not sure that's going to work.

In your repo the strings are like 8u412b08 but in the releases they're like jdk8u412-b08. Stripping the jdk prefix is easy to do with extractVersion but the extra hyphen in the middle of minor and patch might be impossible to overcome for now.

I added #31372 for converting into a feature request issue once requirements are agreed.

[kleini]

Thank you very much for your help!
I extended regex once again to match the version strings on the GitHub release page, but the result stays unmodified. Thank you, opening a new discussion, hopefully resulting in a new feature request.