Unresolved alias - yaml files

[wrighbr]

What would you like help with?

I think I found a bug

How are you running Renovate?

Self-hosted

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

bitbucket

Please tell us more about your question or problem

With the introduction of PR #31336, I've started encountering the following error message: Unresolved alias (the anchor must be set before the alias): when there is an unused anchor in YAML files.

minimal reproduction

https://github.com/wrighbr/minimal-reproduction.

Logs (if relevant)

Logs

{
    "name": "renovate",
    "hostname": "1597d891f62f",
    "pid": 9,
    "level": 50,
    "logContext": "LejI-Khi8SUKXEgS8dDLM",
    "repository": "org/repo",
    "err": {
      "message": "Unresolved alias (the anchor must be set before the alias): ",
      "stack": "ReferenceError: Unresolved alias (the anchor must be set before the alias): \n    at Alias.toJSON (/usr/local/renovate/node_modules/.pnpm/yaml@2.5.1/node_modules/yaml/dist/nodes/Alias.js:42:19)\n    at Object.toJS (/usr/local/renovate/node_modules/.pnpm/yaml@2.5.1/node_modules/yaml/dist/nodes/toJS.js:22:26)\n    at Object.addPairToJSMap (/usr/local/renovate/node_modules/.pnpm/yaml@2.5.1/node_modules/yaml/dist/nodes/addPairToJSMap.js:32:34)\n    at YAMLMap.toJSON (/usr/local/renovate/node_modules/.pnpm/yaml@2.5.1/node_modules/yaml/dist/nodes/YAMLMap.js:124:28)\n    at Object.toJS (/usr/local/renovate/node_modules/.pnpm/yaml@2.5.1/node_modules/yaml/dist/nodes/toJS.js:22:26)\n    at YAMLSeq.toJSON (/usr/local/renovate/node_modules/.pnpm/yaml@2.5.1/node_modules/yaml/dist/nodes/YAMLSeq.js:76:27)\n    at Object.toJS (/usr/local/renovate/node_modules/.pnpm/yaml@2.5.1/node_modules/yaml/dist/nodes/toJS.js:22:26)\n    at Object.addPairToJSMap (/usr/local/renovate/node_modules/.pnpm/yaml@2.5.1/node_modules/yaml/dist/nodes/addPairToJSMap.js:32:34)\n    at YAMLMap.toJSON (/usr/local/renovate/node_modules/.pnpm/yaml@2.5.1/node_modules/yaml/dist/nodes/YAMLMap.js:124:28)\n    at Object.toJS (/usr/local/renovate/node_modules/.pnpm/yaml@2.5.1/node_modules/yaml/dist/nodes/toJS.js:22:26)\n    at Document.toJS (/usr/local/renovate/node_modules/.pnpm/yaml@2.5.1/node_modules/yaml/dist/doc/Document.js:301:26)\n    at parseYaml (/usr/local/renovate/lib/util/yaml.ts:66:34)\n    at Object.extractPackageFile (/usr/local/renovate/lib/modules/manager/helmfile/extract.ts:39:32)\n    at extractPackageFile (/usr/local/renovate/lib/modules/manager/index.ts:75:9)\n    at getManagerPackageFiles (/usr/local/renovate/lib/workers/repository/extract/manager-files.ts:58:43)\n    at /usr/local/renovate/lib/workers/repository/extract/index.ts:57:28\n    at async Promise.all (index 5)\n    at extractAllDependencies (/usr/local/renovate/lib/workers/repository/extract/index.ts:54:26)\n    at extract (/usr/local/renovate/lib/workers/repository/process/extract-update.ts:140:28)\n    at extractDependencies (/usr/local/renovate/lib/workers/repository/process/index.ts:155:26)"
    },
    "msg": "Repository has unknown error",
    "time": "2024-10-10T23:44:51.583Z",
    "v": 0
  }

[github-actions[bot]]

Hi there,

Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. Discussions without reproductions are less likely to be converted to Issues.

Please follow these steps:

1. Read our guide on creating a minimal reproduction.
2. Go to our minimal reproduction template repository.
3. Select the Use this template button to create a new repository based on the template.
4. Work on the minimal reproduction in your own repository.
5. Fill out the information in your repository's README.md.
6. Add the link to your reproduction to the first post of your Discussion. If you are not the original author, you can post a new comment with the link.

If you need help with running renovate on your minimal reproduction repository, please refer to our Running Renovate guide.
Good luck,

The Renovate team

[wrighbr]

minimal reproduction

https://github.com/wrighbr/minimal-reproduction

[rarkins]

Upstream discussion: eemeli/yaml#583

[rarkins]

@secustor was it a deliberate design choice to error when the YAML can't be parsed? It seems to me to be unnecessary to hard exit just because a YAML can't parse (for any reason). e.g.

ERROR: Repository has unknown error (repository=wrighbr/minimal-reproduction)
       "err": {
         "message": "Unresolved alias (the anchor must be set before the alias): ",
         "stack": "ReferenceError: Unresolved alias (the anchor must be set before the alias): \n    at Alias.toJSON (/home/rhys/src/github/renovatebot/renovate/node_modules/.pnpm/yaml@2.5.1/node_modules/yaml/dist/nodes/Alias.js:42:19)\n    at Object.toJS (/home/rhys/src/github/renovatebot/renovate/node_modules/.pnpm/yaml@2.5.1/node_modules/yaml/dist/nodes/toJS.js:22:26)\n    at Object.addPairToJSMap (/home/rhys/src/github/renovatebot/renovate/node_modules/.pnpm/yaml@2.5.1/node_modules/yaml/dist/nodes/addPairToJSMap.js:32:34)\n    at YAMLMap.toJSON (/home/rhys/src/github/renovatebot/renovate/node_modules/.pnpm/yaml@2.5.1/node_modules/yaml/dist/nodes/YAMLMap.js:124:28)\n    at Object.toJS (/home/rhys/src/github/renovatebot/renovate/node_modules/.pnpm/yaml@2.5.1/node_modules/yaml/dist/nodes/toJS.js:22:26)\n    at YAMLSeq.toJSON (/home/rhys/src/github/renovatebot/renovate/node_modules/.pnpm/yaml@2.5.1/node_modules/yaml/dist/nodes/YAMLSeq.js:76:27)\n    at Object.toJS (/home/rhys/src/github/renovatebot/renovate/node_modules/.pnpm/yaml@2.5.1/node_modules/yaml/dist/nodes/toJS.js:22:26)\n    at Object.addPairToJSMap (/home/rhys/src/github/renovatebot/renovate/node_modules/.pnpm/yaml@2.5.1/node_modules/yaml/dist/nodes/addPairToJSMap.js:32:34)\n    at YAMLMap.toJSON (/home/rhys/src/github/renovatebot/renovate/node_modules/.pnpm/yaml@2.5.1/node_modules/yaml/dist/nodes/YAMLMap.js:124:28)\n    at Object.toJS (/home/rhys/src/github/renovatebot/renovate/node_modules/.pnpm/yaml@2.5.1/node_modules/yaml/dist/nodes/toJS.js:22:26)\n    at Document.toJS (/home/rhys/src/github/renovatebot/renovate/node_modules/.pnpm/yaml@2.5.1/node_modules/yaml/dist/doc/Document.js:301:26)\n    at parseYaml (/home/rhys/src/github/renovatebot/renovate/lib/util/yaml.ts:74:34)\n    at Object.extractPackageFile (/home/rhys/src/github/renovatebot/renovate/lib/modules/manager/helmfile/extract.ts:39:32)\n    at extractPackageFile (/home/rhys/src/github/renovatebot/renovate/lib/modules/manager/index.ts:75:9)\n    at getManagerPackageFiles (/home/rhys/src/github/renovatebot/renovate/lib/workers/repository/extract/manager-files.ts:58:43)\n    at async /home/rhys/src/github/renovatebot/renovate/lib/workers/repository/extract/index.ts:57:28\n    at async Promise.all (index 0)\n    at async extractAllDependencies (/home/rhys/src/github/renovatebot/renovate/lib/workers/repository/extract/index.ts:54:26)\n    at async extract (/home/rhys/src/github/renovatebot/renovate/lib/workers/repository/process/extract-update.ts:140:28)\n    at async extractDependencies (/home/rhys/src/github/renovatebot/renovate/lib/workers/repository/process/index.ts:155:26)"

[secustor]

This mimicked the previous behavior before the switch. We can add a safe option equivalent to Zod schemas and refactor the usage for it.
That way we can reduce boiler plate in the managers.

[rarkins]

Half-solution, half-workaround: #31963

The filter option wasn't working as intended