Misunderstanding about matchPackageNames

[KennyLorin]

How are you running Renovate?

Self-hosted Renovate

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

GitLab - ghcr.io/renovatebot/renovate:39.19.1@sha256:70c69d2523448834ae53111d6440d4ad199fe390845f0712ac4128e5740fe2d7

Please tell us more about your question or problem

Hello,

I'm trying to set up renovate to have specific rules for a set of dependencies in a maven project.
Under packageRules, I created a rule containing the packages i want a special treatment for using the matchPackageNames

I validated the regex with regex101 (unescaping backslashes)

Example:

for the packageName "org.springframework:spring-test", I get the following branch name, which is incorrect:

                     "branchName": "renovate/major-the-rest-major"

I first noticed this behavior through the dependency dashboard, which only grouped dependencies by major/minor (patches are not listed since they do not require dashboard approval)

Below is the minimal reproduction of the configuration I'm currently testing:

{
    "$schema": "https://docs.renovatebot.com/renovate-schema.json",
    "extends": ["config:recommended"],
    "enabledManagers": ["maven"],
    "dependencyDashboard": true,
    "packageRules": [
        {
            "matchDepNames": [
                "/org.springframework:.*/",
                "/org.springframework\\..*:.*/"
            ],
            "major": {
                "dependencyDashboardApproval": true,
                "automerge": false,
                "groupName": "strategic-major"
            }
        },
        {
            "matchUpdateTypes": ["major"],
            "dependencyDashboardApproval": false,
            "automerge": true,
            "groupName": "the-rest-major"
        }
    ]
}

Logs (if relevant)

Logs

{
                 "datasource": "maven",
                 "depName": "org.springframework:spring-test",
                 "currentValue": "5.3.39",
                 "fileReplacePosition": 688,
                 "registryUrls": [
                   "https://nexus.albalogic.fr/nexus/content/groups/combined",
                   "https://repo.maven.apache.org/maven2"
                 ],
                 "depType": "test",
                 "groupName": "spring.version",
                 "updates": [
                   {
                     "bucket": "major",
                     "newVersion": "6.2.0",
                     "newValue": "6.2.0",
                     "releaseTimestamp": "2024-11-14T16:38:16.000Z",
                     "newVersionAgeInDays": 6,
                     "newMajor": 6,
                     "newMinor": 2,
                     "newPatch": 0,
                     "updateType": "major",
                     "branchName": "renovate/major-the-rest-major"
                   }
                 ],
                 "packageName": "org.springframework:spring-test",
                 "versioning": "maven",
                 "warnings": [],
                 "sourceUrl": "https://github.com/spring-projects/spring-framework",
                 "registryUrl": "https://repo.maven.apache.org/maven2",
                 "packageScope": "org.springframework",
                 "currentVersion": "5.3.39",
                 "currentVersionTimestamp": "2024-08-14T09:03:00.000Z",
                 "currentVersionAgeInDays": 98,
                 "isSingleVersion": true,
                 "fixedVersion": "5.3.39"
               },

[github-actions[bot]]

Hi there,

This discussion is too complex, and we want you to simplify. This way you are more likely to get help or a solution.

For example, if you've pasted your whole complex config, while your problem is about just one part, consider removing the parts that are not relevant to your problem. The best way to do this is to create a minimal reproduction.

You may have tried many ways to do something, and described all the methods you tried. If none of the methods worked, please focus on the most promising method, or the ideal solution. Avoid complicating the description (or logs) with the failed attempts.

To summarize: please reduce the complexity of your discussion, to increase the chances of getting help.

Thanks, the Renovate team

[KennyLorin]

Right, I've updated the description to include a minimal reproduction.

[rarkins]

Renovate has a hardcoded rule to add the major- prefix to groupings. This is so that Renovate can separate major and non-major groupings when necessary.

[KennyLorin]

To my understanding, that would "just" change the branch names. This is not the issue I'm trying to fix here:
I'm trying to group dependencies from a list together, but the package name matching seems to fail, leading to no grouping being done.

[rarkins]

If you are seeing "branchName": "renovate/major-the-rest-major" then it means grouping is being done. Please be more specific so we don't waste time with misunderstandings.

I suspect you expect the second package rule to only match packages which don't match the first package rule. That is not how package rules work. Package rules are evaluated independently, and the "last" matching package rule wins, if multiple match and they contradict each other. Your second package rule matches all major updates, so all major updates will be in the second group.