Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(yarn): add credentials to .yarnrc.yml #10052

Merged
merged 10 commits into from
May 21, 2021
Merged

feat(yarn): add credentials to .yarnrc.yml #10052

merged 10 commits into from
May 21, 2021

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented May 19, 2021

Changes:

Merges npm hostRules into .yarnrc.yml to enable private authentication in Yarn 2+

Context:

Yarn 2+ does not read credentials from .npmrc.

Closes #9985

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Sorry, something went wrong.

@rarkins rarkins requested a review from viceice May 19, 2021 14:54
viceice
viceice previously approved these changes May 19, 2021
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far

@rarkins rarkins marked this pull request as ready for review May 19, 2021 15:32
@rarkins
Copy link
Collaborator Author

rarkins commented May 20, 2021

Sorry, something went wrong.

@rarkins rarkins marked this pull request as draft May 20, 2021 07:01
@rarkins rarkins dismissed a stale review via 8994222 May 21, 2021 13:43
@rarkins rarkins marked this pull request as ready for review May 21, 2021 13:45
@rarkins
Copy link
Collaborator Author

rarkins commented May 21, 2021

This might not get everything right yet, but I don't think it can make anything worse. So I'd like to merge it as long as it has little chance of breaking anything.

@rarkins rarkins requested a review from viceice May 21, 2021 13:46
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
rarkins and others added 2 commits May 21, 2021 20:38
@rarkins rarkins requested a review from viceice May 21, 2021 19:36
@rarkins rarkins enabled auto-merge (squash) May 21, 2021 20:03
@rarkins rarkins merged commit 714e51a into main May 21, 2021
@rarkins rarkins deleted the feat/9985-yarn-2-auth branch May 21, 2021 20:20
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 25.27.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yarn 2 private registry authentication support
4 participants