Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform: Support lockfile generation for community providers #10550

Closed
hojerst opened this issue Jun 23, 2021 · 7 comments · Fixed by #10619
Closed

Terraform: Support lockfile generation for community providers #10550

hojerst opened this issue Jun 23, 2021 · 7 comments · Fixed by #10619
Labels
manager:terraform Terraform package manager status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality)

Comments

@hojerst
Copy link
Contributor

hojerst commented Jun 23, 2021

What would you like Renovate to be able to do?

Terraform currently supports an experimental feature for generation of terraform lockfiles. However, this only works for providers which are provided by hashicorp. When using community providers, the lockfile is not updated for those. This essentially invalidates the lockfile for community providers. The feature usability would be increased when it also supports community providers.

Did you already have any implementation ideas?

Disclaimer: I don't know the details of the terraform provider hosting, nor am I a expert for the renovate internals, so take the following with a grain of salt. lib/renovate/managers/terraform/lockfile/* could be extended to fetch community zip's from the github.com releases for the respective providers.

@hojerst hojerst added priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started type:bug Bug fix of existing functionality labels Jun 23, 2021
@github-actions
Copy link
Contributor

Thank you for providing a reproduction! 🎉 🚀

The Renovate team will take a look at the reproduction repository.

@viceice
Copy link
Member

viceice commented Jun 23, 2021

I think your issue is the name casing. you are using Telmate/proxmox but it should be telmate/proxmox ? Can you verify it fails with lowercase too?

@hojerst
Copy link
Contributor Author

hojerst commented Jun 23, 2021

I will evaluate, however the provider's name is actually a uppercase T: https://github.com/Telmate/terraform-provider-proxmox and https://registry.terraform.io/providers/Telmate/proxmox/latest

@viceice viceice added the manager:terraform Terraform package manager label Jun 23, 2021
@viceice
Copy link
Member

viceice commented Jun 23, 2021

OK, confirmed, only official providers are supported

const repositoryRegexResult = repositoryRegex.exec(repository);
if (!repositoryRegexResult) {
// non hashicorp builds are not supported at the moment
return null;
}

@hojerst Please replace the bug template with a feature request template

@viceice viceice added type:feature Feature (new functionality) and removed type:bug Bug fix of existing functionality labels Jun 23, 2021
@viceice viceice changed the title Terraform lockfile generation doesn't work with community providers Terraform: Support lockfile generation for community providers Jun 23, 2021
@hojerst
Copy link
Contributor Author

hojerst commented Jun 23, 2021

It doesn't work with telmate/proxmox either. Yesterday I had a look at the code of renovate. When I understand it correctly, renovate always tries to download the zips from releases.hashicorp.com. However this location only host the hashicorp providers (if I'm correct): see https://releases.hashicorp.com/

@hojerst
Copy link
Contributor Author

hojerst commented Jun 23, 2021

I changed the description to a feature request as requested.

@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 25.63.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
manager:terraform Terraform package manager status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants