Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint: Enum Member name ... must match one of the following formats: PascalCase #12556

Closed
viceice opened this issue Nov 8, 2021 · 4 comments · Fixed by #18900
Closed

Lint: Enum Member name ... must match one of the following formats: PascalCase #12556

viceice opened this issue Nov 8, 2021 · 4 comments · Fixed by #18900
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code

Comments

@viceice
Copy link
Member

viceice commented Nov 8, 2021

Describe the proposed change(s).

Enum Member name manifestV1 must match one of the following formats: PascalCase
@viceice viceice added type:refactor Refactoring or improving of existing code status:requirements Full requirements are not yet known, so implementation should not be started priority-5-triage labels Nov 8, 2021
@viceice
Copy link
Member Author

viceice commented Nov 9, 2021

@rarkins @JamieMagee Any preference about enum member consistency, default rule value would be camlCase but i switched it to PascalCase as most of our enums follow that.

@rarkins
Copy link
Collaborator

rarkins commented Nov 9, 2021

No preference

@viceice
Copy link
Member Author

viceice commented Nov 9, 2021

So i suggest to use the default camlCasing as recommend by @typescript-eslint/naming-convention.

@HonkingGoose HonkingGoose added priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:ready and removed status:requirements Full requirements are not yet known, so implementation should not be started priority-5-triage labels Nov 10, 2021
@RahulGautamSingh RahulGautamSingh mentioned this issue Oct 21, 2022
Merged
4 tasks
@RahulGautamSingh RahulGautamSingh mentioned this issue Nov 18, 2022
Merged
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 34.29.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: convert enums to unions RahulGautamSingh/renovate
4 participants
@viceice @rarkins @HonkingGoose @renovate-release