-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove enums from the code base #13743
Comments
What is the reason to remove enums? |
Risks seem to be outweighting the benefits. But doing converting enums for |
Also please check, that const enum compilation result same to union type https://www.typescriptlang.org/play?#code/MYewdgzgLgBApmArgWxgFTtGBvAsAKBiJgHkw4YBeGARgBoDj0B3EKmAJgfwF8CCAZojDAoAS3AwAhgBMZACgAeALnSYodGAE9VGaAEpVSZACM4AJxyMY5uFETmwMRTADU2gNwE++ArIX0nPpe+EA |
Cause of using classic enum in case of |
In context of Renovate, personally my biggest obstacle with enums is that we can't |
Maybe, it's easily solvable, though |
That why i don't like them too. I now always union types instead. |
This comment was marked as resolved.
This comment was marked as resolved.
🎉 This issue has been resolved in version 34.29.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Describe the proposed change(s).
This is an umbrella issue for series of small refactoring PRs
The text was updated successfully, but these errors were encountered: