-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error updating gitlabci includes if pinDigests=true" #14177
Comments
Hi there, Help us by making a minimal reproduction repository. Before we can start work on your issue we first need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. To get started, please read our guide on creating a minimal reproduction to understand what is needed. We may close the issue if you (or someone else) have not provided a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment. Good luck, The Renovate team |
Hi there, We have found that there's a problem with the logs. Depending on which situation applies follow one, some or all of these instructions. No logs at allIf there's no log posted yet, we need you to find and copy/paste the log into the issue template. Finding logs on hosted appClick me to read instructionsIf you use the Renovate app (GitHub):
Finding logs when self-hostingClick me to read instructionsIf you're running self-hosted, run with Insufficient logsClick me to read instructionsIf you already provided logs, and the Renovate team said they are not enough, follow the instructions from the No logs at all section. Formatting your logsClick me to read instructionsPlease put your logs in a
|
Hi, I've created a minimal repo to reproduce the error: https://gitlab.com/oberhaus77/renovate-test Kind regards |
Thanks for the reproduction. Forked to https://github.com/renovate-reproductions/14177 The |
Yes, this is the problem I've seen with current Renovate version 31.81.7 The last version without that problem in our Renovate job seems to be 28.26.0. |
As a workaround, configure
|
Hey, I unfortunately only found this issue after spending some time debugging the problem myself. What is being described matches what I've been able to find out pretty well though. My Workaround was the opposite:
After bisecting the renovate-history I found the version which introduced digest-extraction for GitLab-repositories and also this behaviour. It's v31.17.0 created by this PR: #13361 |
@hasanwhitesource Could something like #15113 work for |
That manager will be merged to gitlabci soon. so it will fixed automatically |
@therufuser @rarkins just to be sure, the workaround was to switch off docker-digests pinning in gitlab-ci? |
I think it's still not fixed? |
I have similar problem with HelmRepository
|
How are you running Renovate?
Self-hosted
If you're self-hosting Renovate, tell us what version of Renovate you run.
31.79.1
Please select which platform you are using if self-hosting.
No response
If you're self-hosting Renovate, tell us what version of the platform you run.
Linux (Docker container)
Was this something which used to work for you, and then stopped?
It used to work, and then stopped
Describe the bug
We have set "pinDigests": true in our renovate json to pin used docker images in Dockerfile etc.
Since 2-3 Weeks our renovate job logs following errors:
Error updating branch: update failure ....
The expected updates are in .gitlab-ci.yml includes.
We invested some time and it seems that in the function confirmIfDepUpdated
is looking for digests where no digests are supported. For example in .gitlab-ci.yml includes.
Is there a config change we missed or is this a bug?
Relevant debug logs
Logs
Have you created a minimal reproduction repository?
Example Repository
The text was updated successfully, but these errors were encountered: