Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese file names are renamed incorrectly every time in PR. #15538

Closed
kondei opened this issue May 11, 2022 · 11 comments · Fixed by #18963
Closed

Japanese file names are renamed incorrectly every time in PR. #15538

kondei opened this issue May 11, 2022 · 11 comments · Fixed by #18963
Labels
help wanted Help is needed or welcomed on this issue priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:bug Bug fix of existing functionality

Comments

@kondei
Copy link

kondei commented May 11, 2022

How are you running Renovate?

WhiteSource Renovate hosted app on github.com

If you're self-hosting Renovate, tell us what version of Renovate you run.

No response

Please select which platform you are using if self-hosting.

No response

If you're self-hosting Renovate, tell us what version of the platform you run.

No response

Was this something which used to work for you, and then stopped?

I never saw this working

Describe the bug

Japanese file names are renamed incorrectly every time in pull requests.
I show an example below.

original file name:
技術選定.md

first PR commit diff on console:

rename from 技術選定.md
rename to "\"\\346\\212\\200\\350\\241\\223\\351\\201\\270\\345\\256\\232.md\""

second PR commit diff on console:

rename from "\"\\346\\212\\200\\350\\241\\223\\351\\201\\270\\345\\256\\232.md\""
rename to "\"\\\"\\\\346\\\\212\\\\200\\\\350\\\\241\\\\223\\\\351\\\\201\\\\270\\\\345\\\\256\\\\232.md\\\"\""

and more...

diff image on PR page:

スクリーンショット 2022-05-11 11 23 27

Relevant debug logs

Sorry, I could not find out the job corresponding to each commit or PR on https://app.renovatebot.com/dashboard .

Have you created a minimal reproduction repository?

https://github.com/kondei/minimal-reporoduction-renovate-unicode-issue/pull/3/files

@kondei kondei added priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started type:bug Bug fix of existing functionality labels May 11, 2022
@rarkins rarkins added help wanted Help is needed or welcomed on this issue auto:reproduction A minimal reproduction is necessary to proceed labels May 11, 2022
@github-actions
Copy link
Contributor

Hi there,

Get your issue fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.

To get started, please read our guide on creating a minimal reproduction.

We may close the issue if you, or someone else, haven't created a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.

Good luck,

The Renovate team

@viceice
Copy link
Member

viceice commented May 11, 2022

looks like a Unicode issue. can be caused by renovate itself, simple-git or nodejs.

@kondei
Copy link
Author

kondei commented May 13, 2022

I created reproduction at https://github.com/kondei/minimal-reporoduction-renovate-unicode-issue/pull/3/files .
I am sorry, I am not so sure that renovate.json in the repository is really minimal.

@rarkins rarkins added reproduction:provided priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others and removed auto:reproduction A minimal reproduction is necessary to proceed status:requirements Full requirements are not yet known, so implementation should not be started priority-5-triage labels May 13, 2022
@PhilipAbed
Copy link
Collaborator

i'm unable to confirm reproduction since i get an error:

 WARN: Host error (repository=StinkyLord/japanese-name)
       "hostType": "npm",
       "packageName": "@storybook/addon-actions",
       "err": {
         "name": "RequestError",
         "code": "ETIMEDOUT",
         "timings": {
           "start": 1652791294373,
           "socket": 1652791294374,
           "lookup": 1652791294523,
           "error": 1652791315564,
           "phases": {"wait": 1, "dns": 149, "total": 21191}
         },
         "message": "connect ETIMEDOUT 2606:4700::6810:1123:443",
         "stack": "RequestError: connect ETIMEDOUT 2606:4700::6810:1123:443\n    at ClientRequest.<anonymous> (C:\\github\\renovateWs\\node_modules\\got\\dist\\source\\core\\index.js:962:111)\n    at Object.onceWrapper (node:events:
640:26)\n    at ClientRequest.emit (node:events:532:35)\n    at ClientRequest.emit (node:domain:475:12)\n    at ClientRequest.origin.emit (C:\\github\\renovateWs\\node_modules\\@szmarczak\\http-timer\\dist\\source\\index.js:43:20)\n
    at TLSSocket.socketErrorListener (node:_http_client:442:9)\n    at TLSSocket.emit (node:events:520:28)\n    at TLSSocket.emit (node:domain:475:12)\n    at emitErrorNT (node:internal/streams/destroy:164:8)\n    at emitErrorCloseN
T (node:internal/streams/destroy:129:3)\n    at processTicksAndRejections (node:internal/process/task_queues:83:21)\n    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1157:16)",
         "options": {
           "headers": {
             "user-agent": "RenovateBot/0.0.0-semantic-release (https://github.com/renovatebot/renovate)",
             "accept": "application/json",
             "accept-encoding": "gzip, deflate, br"
           },
           "url": "https://registry.npmjs.org/@storybook%2Faddon-actions",
           "hostType": "npm",
           "username": "",
           "password": "",
           "method": "GET",
           "http2": false
         }
       }
 INFO: External host error causing abort - skipping (repository=StinkyLord/japanese-name)

@rarkins rarkins added auto:reproduction A minimal reproduction is necessary to proceed and removed reproduction:provided labels May 18, 2022
@rarkins
Copy link
Collaborator

rarkins commented May 18, 2022

OK, we need a reproduction which doesn't use any private packages

@hannoeru
Copy link

@rarkins
@storybook/addon-actions is a public package from storybook.

FYI: https://www.npmjs.com/package/@storybook/addon-actions/v/6.4.13

@rarkins rarkins added reproduction:provided and removed auto:reproduction A minimal reproduction is necessary to proceed labels May 18, 2022
@renovatebot renovatebot deleted a comment from github-actions bot May 18, 2022
@rarkins
Copy link
Collaborator

rarkins commented May 18, 2022

In that case @PhilipAbed this sounds like a problem in your environment

@PhilipAbed
Copy link
Collaborator

i noticed it happened on another repository too, its random, ill try to reproduce again.

@rarkins
Copy link
Collaborator

rarkins commented May 18, 2022

Could be related to IPv6, based on your logs

@KisaragiEffective
Copy link

maybe this issue can be closed, since #18963 was merged

@viceice viceice closed this as completed Apr 13, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Help is needed or welcomed on this issue priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:bug Bug fix of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants