Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in helm v3 manager does not bump the version of the chart #17681

Closed
kilokang opened this issue Sep 7, 2022 · 6 comments
Closed

Regression in helm v3 manager does not bump the version of the chart #17681

kilokang opened this issue Sep 7, 2022 · 6 comments
Labels
auto:logs Issue or Discussion is needs logs/more logs auto:reproduction A minimal reproduction is necessary to proceed manager:helm Helm package manager stale status:requirements Full requirements are not yet known, so implementation should not be started type:bug Bug fix of existing functionality

Comments

@kilokang
Copy link

kilokang commented Sep 7, 2022

How are you running Renovate?

Mend Renovate hosted app on github.com

Was this something which used to work for you, and then stopped?

It used to work, and then stopped

Describe the bug

It is known that renovate is unable to bump the version of the chart when it is updating helm-values: #8231

But until yesterday, the chart version was raised without any issue while updating dependencies to other charts in the Chart.yaml file but the last attempts are not bumping it.

Have you created a minimal reproduction repository?

No reproduction, but I have linked to a public repo where it occurs

@kilokang kilokang added priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started type:bug Bug fix of existing functionality labels Sep 7, 2022
@viceice viceice added manager:helm Helm package manager auto:reproduction A minimal reproduction is necessary to proceed auto:logs Issue or Discussion is needs logs/more logs labels Sep 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

Hi there,

Get your issue fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.

To get started, please read our guide on creating a minimal reproduction.

We may close the issue if you, or someone else, haven't created a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.

Good luck,

The Renovate team

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

Hi there,

We have found that there's a problem with the logs. Depending on which situation applies follow one, some or all of these instructions.

No logs at all

If you haven't posted any log yet, we need you to find and copy/paste the log into the issue template.

Finding logs on hosted app

Click me to read instructions

If you use the Renovate app (GitHub):

  1. Go to the affected PR, and search for "View repository job log here"
  2. Click on the link to go to the "Mend Renovate Dashboard" and log in
  3. You are now in the correct repository log overview screen
  4. Copy/paste the correct log
  5. Follow the steps in the formatting your logs section

Finding logs when self-hosting

Click me to read instructions

If you're running self-hosted, run with LOG_LEVEL=debug in your environment variables and search for whatever dependency/branch/PR that is causing the problem.

Insufficient logs

Click me to read instructions

If you already gave us a log, and the Renovate team said it's not enough, then follow the instructions from the No logs at all section.

Formatting your logs

Click me to read instructions

Please put your logs in a <details> and <summary> element like this:

<details><summary>Click me to see logs</summary>

```
Copy/paste your logs here, between the starting and ending backticks
```

</details>

@kilokang
Copy link
Author

kilokang commented Sep 7, 2022

Hello there~

I am not able to create a more valid reproduction environment than the one I have just passed where there are two PRs created in a different moment that one works and the other one do not.

The same dependency is used in other charts that are also failling:

But it is working on this one:

Logs from Mend Renovate Dashboard

newrelic/helm-charts: #803510665
DEBUG: latest commit(branch="renovate/common-library-1.x")
{
  "branchName": "master",
  "latestCommitDate": "2022-09-07T13:35:40+02:00"
}
DEBUG: manager.getUpdatedPackageFiles() reuseExistingBranch=false(branch="renovate/common-library-1.x")
DEBUG: Starting search at index 529(packageFile="charts/newrelic-logging/Chart.yaml", branch="renovate/common-library-1.x")
{
  "depName": "common-library"
}
DEBUG: Found match at index 529(packageFile="charts/newrelic-logging/Chart.yaml", branch="renovate/common-library-1.x")
{
  "depName": "common-library"
}
DEBUG: Checking if we should bump Chart.yaml version(branch="renovate/common-library-1.x")
{
  "bumpVersion": "patch",
  "currentValue": "1.11.7"
}
DEBUG: (branch="renovate/common-library-1.x")
{
  "newChartVersion": "1.11.8"
}
DEBUG: Bumped Chart.yaml version(branch="renovate/common-library-1.x")
DEBUG: Contents updated(packageFile="charts/newrelic-logging/Chart.yaml", branch="renovate/common-library-1.x")
{
  "depName": "common-library"
}
DEBUG: helmv3.updateArtifacts(charts/newrelic-logging/Chart.yaml)(branch="renovate/common-library-1.x")
newrelic/nri-kubernetes: #803544881
DEBUG: latest commit(branch="renovate/common-library-1.x")
{
  "branchName": "main",
  "latestCommitDate": "2022-08-30T10:08:45+02:00"
}
DEBUG: manager.getUpdatedPackageFiles() reuseExistingBranch=false(branch="renovate/common-library-1.x")
DEBUG: Starting search at index 624(packageFile="charts/newrelic-infrastructure/Chart.yaml", branch="renovate/common-library-1.x")
{
  "depName": "common-library"
}
DEBUG: Found match at index 624(packageFile="charts/newrelic-infrastructure/Chart.yaml", branch="renovate/common-library-1.x")
{
  "depName": "common-library"
}
DEBUG: Contents updated(packageFile="charts/newrelic-infrastructure/Chart.yaml", branch="renovate/common-library-1.x")
{
  "depName": "common-library"
}
DEBUG: helmv3.updateArtifacts(charts/newrelic-infrastructure/Chart.yaml)(branch="renovate/common-library-1.x")
DEBUG: Updating charts/newrelic-infrastructure/Chart.lock(branch="renovate/common-library-1.x")
DEBUG: Setting BUILDPACK_CACHE_DIR to /tmp/containerbase(branch="renovate/common-library-1.x")
DEBUG: Using docker to execute(branch="renovate/common-library-1.x")
{
  "image": "sidecar"
}
DEBUG: Resolved stable matching version(branch="renovate/common-library-1.x")
{
  "toolName": "helm",
  "resolvedVersion": "v3.9.4"
}
DEBUG: containerbaseDir is separate from cacheDir(branch="renovate/common-library-1.x")
DEBUG: No tag or tagConstraint specified(branch="renovate/common-library-1.x")
{
  "image": "docker.io/renovate/sidecar"
}
DEBUG: Fetching Docker image: docker.io/renovate/sidecar(branch="renovate/common-library-1.x")
DEBUG: Finished fetching Docker image docker.io/renovate/sidecar@sha256:423341d5cb7302ba76f1cd7945cb6b61e76e69ee153af824560ba4ec4e50bf7d(branch="renovate/common-library-1.x")
DEBUG: Executing command(branch="renovate/common-library-1.x")
{
  "command": "docker run --rm --name=renovate_sidecar --label=renovate_child -v \"/mnt/renovate/gh/newrelic/nri-kubernetes\":\"/mnt/renovate/gh/newrelic/nri-kubernetes\" -v \"/tmp/renovate-cache\":\"/tmp/renovate-cache\" -v \"/tmp/containerbase\":\"/tmp/containerbase\" -e HELM_EXPERIMENTAL_OCI -e BUILDPACK_CACHE_DIR -w \"/mnt/renovate/gh/newrelic/nri-kubernetes\" docker.io/renovate/sidecar bash -l -c \"install-tool helm v3.9.4 && helm repo add stable --registry-config /tmp/renovate-cache/__renovate-private-cache/registry.json --repository-config /tmp/renovate-cache/__renovate-private-cache/repositories.yaml --repository-cache /tmp/renovate-cache/__renovate-private-cache/repositories https://charts.helm.sh/stable && helm repo add common-library --registry-config /tmp/renovate-cache/__renovate-private-cache/registry.json --repository-config /tmp/renovate-cache/__renovate-private-cache/repositories.yaml --repository-cache /tmp/renovate-cache/__renovate-private-cache/repositories https://helm-charts.newrelic.com && helm dependency update --registry-config /tmp/renovate-cache/__renovate-private-cache/registry.json --repository-config /tmp/renovate-cache/__renovate-private-cache/repositories.yaml --repository-cache /tmp/renovate-cache/__renovate-private-cache/repositories charts/newrelic-infrastructure\""
}
DEBUG: exec completed(branch="renovate/common-library-1.x")
{
  "cmd": "docker run --rm --name=renovate_sidecar --label=renovate_child -v \"/mnt/renovate/gh/newrelic/nri-kubernetes\":\"/mnt/renovate/gh/newrelic/nri-kubernetes\" -v \"/tmp/renovate-cache\":\"/tmp/renovate-cache\" -v \"/tmp/containerbase\":\"/tmp/containerbase\" -e HELM_EXPERIMENTAL_OCI -e BUILDPACK_CACHE_DIR -w \"/mnt/renovate/gh/newrelic/nri-kubernetes\" docker.io/renovate/sidecar bash -l -c \"install-tool helm v3.9.4 && helm repo add stable --registry-config /tmp/renovate-cache/__renovate-private-cache/registry.json --repository-config /tmp/renovate-cache/__renovate-private-cache/repositories.yaml --repository-cache /tmp/renovate-cache/__renovate-private-cache/repositories https://charts.helm.sh/stable && helm repo add common-library --registry-config /tmp/renovate-cache/__renovate-private-cache/registry.json --repository-config /tmp/renovate-cache/__renovate-private-cache/repositories.yaml --repository-cache /tmp/renovate-cache/__renovate-private-cache/repositories https://helm-charts.newrelic.com && helm dependency update --registry-config /tmp/renovate-cache/__renovate-private-cache/registry.json --repository-config /tmp/renovate-cache/__renovate-private-cache/repositories.yaml --repository-cache /tmp/renovate-cache/__renovate-private-cache/repositories charts/newrelic-infrastructure\"",
  "durationMs": 23355,
  "stdout": "installing v2 tool helm v3.9.4\nlinking tool helm v3.9.4\nversion.BuildInfo{Version:\"v3.9.4\", GitCommit:\"dbc6d8e20fe1d58d50e6ed30f09a04a77e4c68db\", GitTreeState:\"clean\", GoVersion:\"go1.17.13\"}\nInstalled v2 /usr/local/buildpack/tools/v2/helm.sh in 2 seconds\n\"stable\" has been added to your repositories\n\"common-library\" has been added to your repositories\nHang tight while we grab the latest from your chart repositories...\n...Successfully got an update from the \"common-library\" chart repository\n...Successfully got an update from the \"stable\" chart repository\nUpdate Complete. ⎈Happy Helming!⎈\nSaving 1 charts\nDownloading common-library from repo https://helm-charts.newrelic.com\nDeleting outdated charts\n",
  "stderr": ""
}
DEBUG: Returning updated Chart.lock(branch="renovate/common-library-1.x")
DEBUG: Updated 1 package files(branch="renovate/common-library-1.x")
DEBUG: Updated 1 lock files(branch="renovate/common-library-1.x")
{
  "updatedArtifacts": [
    "charts/newrelic-infrastructure/Chart.lock"
  ]
}
DEBUG: 2 file(s) to commit(branch="renovate/common-library-1.x")
DEBUG: Preparing files for committing to branch renovate/common-library-1.x(branch="renovate/common-library-1.x")
DEBUG: Setting git author name(branch="renovate/common-library-1.x")
{
  "gitAuthorName": "Renovate Bot"
}
DEBUG: Setting git author email(branch="renovate/common-library-1.x")
{
  "gitAuthorEmail": "bot@renovateapp.com"
}
DEBUG: git commit(branch="renovate/common-library-1.x")
{
  "deletedFiles": [],
  "ignoredFiles": [],
  "result": {
    "author": null,
    "branch": "renovate/common-library-1.x",
    "commit": "c5cb6ee04d20a995fa824bbec95961e0909fc07c",
    "root": false,
    "summary": {
      "changes": 2,
      "insertions": 4,
      "deletions": 4
    }
  }
}
DEBUG: resetToCommit(067b2be636022c50fc26bcf96db38f06099cb7a4)(branch="renovate/common-library-1.x")
DEBUG: Fetching branch renovate/common-library-1.x(branch="renovate/common-library-1.x")
INFO: Branch created(branch="renovate/common-library-1.x")
{
  "commitSha": "bf8a51959ce74136d4b858b7e762233b6c891b33"
}
DEBUG: Ensuring PR(branch="renovate/common-library-1.x")
DEBUG: There are 0 errors and 0 warnings(branch="renovate/common-library-1.x")
DEBUG: getBranchPr(renovate/common-library-1.x)(branch="renovate/common-library-1.x")
DEBUG: findPr(renovate/common-library-1.x, undefined, open)(branch="renovate/common-library-1.x")
DEBUG: findPr(renovate/common-library-1.x, undefined, closed)(branch="renovate/common-library-1.x")
DEBUG: Found PR #516(branch="renovate/common-library-1.x")
DEBUG: Fetching changelog: https://github.com/newrelic/helm-charts (1.0.6 -> 1.1.0)(branch="renovate/common-library-1.x")
DEBUG: Creating PR(branch="renovate/common-library-1.x")
{
  "prTitle": "chore(deps): update helm release common-library to v1.1.0"
}
DEBUG: Creating PR(branch="renovate/common-library-1.x")
{
  "title": "chore(deps): update helm release common-library to v1.1.0",
  "head": "newrelic:renovate/common-library-1.x",
  "base": "main",
  "draft": false
}
DEBUG: PR created(branch="renovate/common-library-1.x")
{
  "pr": 540,
  "draft": false
}
DEBUG: Adding labels '' to #540(branch="renovate/common-library-1.x")
INFO: PR created(branch="renovate/common-library-1.x")
{
  "pr": 540,
  "prTitle": "chore(deps): update helm release common-library to v1.1.0"
}
DEBUG: addParticipants(pr=540)(branch="renovate/common-library-1.x")
DEBUG: Created Pull Request #540(branch="renovate/common-library-1.x")
DEBUG: PR is not configured for automerge(branch="renovate/common-library-1.x")

The only difference I can see is that in the one that is not working it jumps directly from

DEBUG: Found match at index 624(packageFile="charts/newrelic-infrastructure/Chart.yaml",

To:

DEBUG: Contents updated(packageFile="charts/newrelic-infrastructure/Chart.yaml", branch="renovate/common-library-1.x")

without even testing

DEBUG: Checking if we should bump Chart.yaml version(branch="renovate/common-library-1.x")

I cannot give you logs from the same repository because the successful run was 9 days ago and I have logs up to 4 days ago, sorry.

@github-actions
Copy link
Contributor

When a bug has been marked as needing a reproduction, it means nobody can work on it until one is provided. In cases where no reproduction is possible, or the issue creator does not have the time to reproduce, we unfortunately need to close such issues as they are non-actionable and serve no benefit by remaining open. This issue will be closed after 7 days of inactivity.

@github-actions github-actions bot added the stale label Sep 22, 2022
@github-actions
Copy link
Contributor

This bug report has been closed as we need a reproduction to work on this. If the original poster or anybody else with the same problem discovers that they can reproduce it, please create a new issue, and reference this issue.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 29, 2022
@kilokang
Copy link
Author

kilokang commented Oct 3, 2022

I was able to reproduce it again but only that day.

That day GitHub also had an incident regarding Actions: https://www.githubstatus.com/incidents/sqcs1d0yk16q

We also had a broken pipeline that, to be able to fix it, we had to close and reopen the PR with the same commits from another branch. So I think that the pipeline simply glitched.

I am sorry for the possible noise I could have made.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto:logs Issue or Discussion is needs logs/more logs auto:reproduction A minimal reproduction is necessary to proceed manager:helm Helm package manager stale status:requirements Full requirements are not yet known, so implementation should not be started type:bug Bug fix of existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants