refactor(config-migration): invoke applyPrettierFormatting at the commit stage
#18150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
reviewed
Oct 6, 2022
lib/workers/repository/config-migration/branch/migrated-data.ts
Outdated
Show resolved
Hide resolved
rarkins
previously approved these changes
Oct 14, 2022
rename getAsync to get
rarkins
previously approved these changes
Oct 17, 2022
viceice
reviewed
Oct 19, 2022
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
martincerveny
previously approved these changes
Nov 1, 2022
rarkins
reviewed
Nov 1, 2022
viceice
reviewed
Nov 7, 2022
lib/workers/repository/config-migration/branch/migrated-data.ts
Outdated
Show resolved
Hide resolved
viceice
approved these changes
Nov 8, 2022
|
🎉 This PR is included in version 34.26.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Now comparing existing
renovate.configfile and the newly generated config file hashes (whitespaces omitted) instead of raw strings. This way we are not reliant on theapplyPrettierFormattingfunction when doing so.Moved
applyPrettierFormattinginto the static factory class.Now
applyPrettierFormattingis only invokes before committing (in this stage the we already cloned).Context
applyPrettierFormattingto later in code #17336Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: