Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(github): catch fork list failures gracefully #18933

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Nov 16, 2022

Changes

Adds try/catch to the fork listing function, which can throw.

Context

Private repos fail at this step when in fork mode

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice November 16, 2022 05:42
@rarkins rarkins merged commit 9562cf4 into main Nov 16, 2022
@rarkins rarkins deleted the fix/fork-list-404 branch November 16, 2022 06:01
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.26.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants