fix(manager/pub): extract sdk constraint correctly #23367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeshuaro
changed the title
viceice
requested changes
Jul 17, 2023
zeshuaro
commented
Jul 18, 2023
viceice
reviewed
Jul 20, 2023
viceice
reviewed
Jul 24, 2023
viceice
reviewed
Jul 25, 2023
zharinov
suggested changes
Aug 5, 2023
viceice
reviewed
Aug 5, 2023
zharinov
reviewed
Aug 6, 2023
zharinov
approved these changes
Aug 6, 2023
Co-authored-by: Sergei Zharinov <zharinov@users.noreply.github.com>
zharinov
approved these changes
Aug 6, 2023
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
zharinov
approved these changes
Aug 7, 2023
viceice
approved these changes
Aug 7, 2023
viceice
changed the title
|
🎉 This PR is included in version 36.35.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix the pub manager to extract SDK constraint correctly for running artifacts update by parsing the
pubspec.lockfile which is a YAML file instead of using regex.Context
I don't think there are any logs when extracting the SDK constraint, but basically the current implementation of
getFlutterConstraintandgetDartConstraintalways returnundefinedfor my Flutter app repository, which means the latest version of Flutter is always being used.Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: