Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(result): Support wrapping Zod schemas #23725

Merged
merged 2 commits into from
Aug 6, 2023
Merged

feat(result): Support wrapping Zod schemas #23725

merged 2 commits into from
Aug 6, 2023

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Aug 6, 2023 •
edited
Loading

Changes

Provide convenience methods for wrapping Zod schema into the parser functions that return Result and AsyncResult.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov requested a review from viceice August 6, 2023 14:42
viceice
viceice reviewed Aug 6, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/util/result.ts Outdated Show resolved Hide resolved
@zharinov zharinov requested a review from viceice August 6, 2023 16:12
@viceice viceice enabled auto-merge August 6, 2023 16:40
@viceice viceice added this pull request to the merge queue Aug 6, 2023
Merged via the queue into renovatebot:main with commit c5c9969 Aug 6, 2023
34 checks passed
@viceice viceice deleted the feat/result-wrap-zod-schema branch August 6, 2023 16:48
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.34.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zharinov @renovate-release @viceice