Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create workarounds:disablePerlUpdates preset #23900

Open
HonkingGoose opened this issue Aug 16, 2023 · 3 comments
Open

Create workarounds:disablePerlUpdates preset #23900

HonkingGoose opened this issue Aug 16, 2023 · 3 comments
Labels
core:config Related to config capabilities and presets good first issue Suitable for new contributors priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@HonkingGoose
Copy link
Collaborator

HonkingGoose commented Aug 16, 2023

Describe the proposed change(s).

Create a new workarounds:disablePerlUpdates preset, with this content:

{
  "packageRules": [
    {
      "matchManagers": ["cpanfile"],
      "matchPackageNames": ["perl"],
      "enabled": false
    }
  ]
}

The new preset should also be put in the extends array of the workarounds:all preset, because we want to disable Perl updates by default. Users will have to opt-in explicitly.

Edit: changed the text above due to @rarkins's comment below.

Describe why we need/want these change(s).

Allow users that build applications to opt-in to Perl updates, if they don't need to care about other users.

@HonkingGoose HonkingGoose added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others good first issue Suitable for new contributors status:ready core:config Related to config capabilities and presets labels Aug 16, 2023
@rarkins
Copy link
Collaborator

rarkins commented Aug 16, 2023

I think we can put it in the workarounds:all though, because users can opt into updating perl by adding the preset to ignorePresets

@HonkingGoose
Copy link
Collaborator Author

@rarkins I'm confused, because by default Renovate updates all package files that it finds... But you're saying you want users to opt-in to Perl updates? I must be missing some context here?

@rarkins
Copy link
Collaborator

rarkins commented Aug 21, 2023

Yes, that's right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core:config Related to config capabilities and presets good first issue Suitable for new contributors priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

2 participants