fix(git-url): clean up state of parsed URL

[lcobucci]

Changes

This ensures the state of parsedUrl doesn't have authentication credentials prior to appending the authentication tokens.

Context

This is meant to verify and solve the issue described here.

Documentation

• I have updated the documentation, or
• No documentation update is required

How I've tested my work

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository

[lcobucci]

@Shegox it should be good now :)

[lcobucci]

@Shegox do you know if the broken tests are related to real expectations?

[Shegox]

I'm not sure, I haven't seen the syntax with the username being part of the hostRule in the wild.
As the test was added by @lfcyja in #23354, maybe they can add some insights. Thanks!

[viceice]

needs prettier fix

[lcobucci]

I'm not sure, I haven't seen the syntax with the username being part of the hostRule in the wild. As the test was added by @lfcyja in #23354, maybe they can add some insights. Thanks!

Looking at the patch, it doesn't seem strictly related - more like side effects of the status quo. @Shegox should we move forward with this? If so, I'll fix the test expectations and address the coding style issues.

[Shegox]

Looks good and for GitHub and GitLab this should work as expected. For the other platforms I personally don't see a reason why the "user" should be part of the URL in the user@domain syntax.

@rarkins @viceice could you please take a look at this PR and how we should proceed. Thanks!

[renovate-release]

🎉 This PR is included in version 36.93.7 🎉

The release is available on:

• GitHub release
• 36.93.7

Your semantic-release bot 📦🚀

[8164933729]

Wyd