-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bundler): Set exec cwd to lock file #24379
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg2m
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably needs test changes
@viceice added a test, thanks for the suggestion |
🎉 This PR is included in version 36.93.6 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
Execute bundler commands for artifacts based on lock file path.
Context
Given that Gemfile.lock is in the root directory of the project and Gemfile or Gemfiles are in subdirectories (e.g.:
teamA/Gemfile
) then bundler would have been executed under./teamA
path missing the root folder lock file and therefore only updating the Gemfile and not the lock fileDocumentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
Tested against: jorge-wonolo/renovate-test#12