Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bun: support parsing bun.lockb to detect locked versions #24462

Closed
rarkins opened this issue Sep 16, 2023 · 4 comments
Closed

bun: support parsing bun.lockb to detect locked versions #24462

rarkins opened this issue Sep 16, 2023 · 4 comments
Labels
manager:bun priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Sep 16, 2023

Describe the proposed change(s).

Parse barn.lockb so that each dependency's lockedVersion can be known.

This would enable more accurate detection of currentVersion, and rangeStrategy=pin, but not immediately rangeStrategy=update-lockfile

@rarkins rarkins added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:ready labels Sep 16, 2023
@rarkins rarkins added status:blocked Issue is blocked by another issue or external requirement and removed status:ready labels Sep 18, 2023
@HonkingGoose

This comment was marked as resolved.

@rarkins rarkins added status:requirements Full requirements are not yet known, so implementation should not be started and removed status:blocked Issue is blocked by another issue or external requirement labels Oct 16, 2023
@rarkins
Copy link
Collaborator Author

rarkins commented Oct 16, 2023

Switched back to status:requirements. The challenge here is how to parse the lock file. e.g.

  • "reverse engineer" the format and parse it in JS, or
  • Break our rule of "no binary tools during extract process" and run bun (e.g. to convert to yarn.lock format and then parse)

Reverse engineering sounds bad but reality is that's what we do for non-binary lock file formats for every other manager.

@hyrious
Copy link

hyrious commented May 6, 2024

"reverse engineer" the format and parse it in JS

Just did that -- https://github.com/hyrious/bun.lockb.

It's still experimental and useless (only translates the bun.lockb to yarn lockfile v1, no reverse), let me know if you find any issues or need some features.

@rarkins
Copy link
Collaborator Author

rarkins commented Jun 15, 2024

We’ll wait for the non binary bun lock file instead: oven-sh/bun#11863

@rarkins rarkins closed this as not planned Won't fix, can't repro, duplicate, stale Jun 15, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
manager:bun priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

4 participants