Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/cargo): support for git dependencies #26531

Open
secustor opened this issue Jan 6, 2024 Discussed in #26521 · 2 comments
Open

feat(manager/cargo): support for git dependencies #26531

secustor opened this issue Jan 6, 2024 Discussed in #26521 · 2 comments
Assignees
Labels
manager:cargo Cargo/Rust/crates.io priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@secustor
Copy link
Collaborator

secustor commented Jan 6, 2024

Discussed in #26521

Originally posted by richvdh January 5, 2024

Tell us more.

https://github.com/richvdh/renovate-cargo-git-test is an example of a Cargo project with a git dependency. Cargo.lock is out of date, and can be updated with cargo update -p empty-git-lib.

Renovate reports:

{
  "baseBranch": "main"
  "config": {
    "cargo": [
      {
        "deps": [
          {
            "currentValue": "0.1.0",
            "datasource": "crate",
            "depName": "empty-git-lib",
            "depType": "dependencies",
            "lockedVersion": "0.1.0",
            "managerData": {
              "nestedVersion": true
            },
            "packageName": "empty-git-lib",
            "skipReason": "git-dependency",
            "updates": []
          }
        ],
        "lockFiles": [
          "Cargo.lock"
        ],
        "packageFile": "Cargo.toml"
      }
    ]
  }
}

My understanding, looking at the source, is that Renovate will refuse to touch any dependency that comes from a git repo. It would be great if support could be added!

Reproduction: https://github.com/renovate-reproductions/26531

@secustor secustor added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others manager:cargo Cargo/Rust/crates.io labels Jan 6, 2024
@philbucher
Copy link

Hi,
This would also be very useful for me.

I noticed that git-dependencies are supported for poetry, perhaps the same concepts could be used here?

@mkniewallner
Copy link
Contributor

Hi, This would also be very useful for me.

I noticed that git-dependencies are supported for poetry, perhaps the same concepts could be used here?

Planning to add support for it, being also interested by that feature (so feel free to assign the issue to me), but ideally not until #31260 is merged.

@rarkins rarkins assigned mkniewallner and unassigned philbucher Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
manager:cargo Cargo/Rust/crates.io priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

3 participants