Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/pep621): extract locked versions from pdm.lock #27694

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

Churro
Copy link
Collaborator

@Churro Churro commented Mar 3, 2024

Changes

Adds parsing capabilities for pdm.lock files. This enables the extraction of locked versions from pdm.lock analogous to what others managers do (e.g., poetry in schema.ts and extract.ts).

For separation of concerns, I added a new extractLockedVersions() method since process() is still extracting dev dependencies and wouldn't even proceed if no tool.pdm section exists in pyproject.toml. However, this section is optional, so to identify pdm, a check for build-system was added in extractLockedVersions().

Context

I'm testing the different managers with osv.dev and noticed that no vulnerability alerts are created for pep621 / pdm if dependencies are not declared with exact versions. This is fixed by this PR with the extraction of locked versions (see test repo below).

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Test repo: renovate-demo/renovate-osv-pypi#5

@rarkins rarkins added this pull request to the merge queue Mar 4, 2024
Merged via the queue into renovatebot:main with commit c2be56d Mar 4, 2024
35 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.226.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants