Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terragunt): ignore port when creating registry urls #28653

Merged

Conversation

lstoeferle
Copy link
Contributor

@lstoeferle lstoeferle commented Apr 25, 2024

Changes

This PR fixes a small edge-case for the terragrunt manager, where the registryUrl should ignore the port defined in the terragrunt file.

Example:

terraform {
  source = "git::ssh://gitlab.example.com:1234/hashicorp/example?ref=v1.0.0"
}

Currently results in

{
  "registryUrls": ["https://gitlab.example.com:1234"]
}

but should result into

{
  "registryUrls": ["https://gitlab.example.com"]
}

Context

Forward fix for #28075

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins added this pull request to the merge queue Apr 26, 2024
Merged via the queue into renovatebot:main with commit ec9f553 Apr 26, 2024
35 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.325.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants