Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(http): deprecate dnsCache option #29445

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

viceice
Copy link
Member

@viceice viceice commented Jun 5, 2024

Changes

docs only deprecation.

Context

We talked about removing this feature, i think it's not much used.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested a review from rarkins June 5, 2024 07:12
@viceice viceice changed the title feat(http): deprecate dns cache option feat(http): deprecate dnsCache option Jun 5, 2024
@rarkins rarkins added this pull request to the merge queue Jun 5, 2024
Merged via the queue into main with commit d8c3440 Jun 5, 2024
37 checks passed
@rarkins rarkins deleted the feat/dns-cache-deprecation branch June 5, 2024 08:04
@viceice
Copy link
Member Author

viceice commented Jun 5, 2024

@rarkins should we remove in v38? or too early?

@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.391.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

kosmoz pushed a commit to kosmoz/renovate that referenced this pull request Jun 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants