feat(instrumentation): add option to overwrite otlp service name/namespace/version with env var #29583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aviv Guiser <avivguiser@gmail.com>
|
|
KyriosGN0
changed the title
secustor
reviewed
Jun 10, 2024
Signed-off-by: Aviv Guiser <avivguiser@gmail.com>
secustor
reviewed
Jun 11, 2024
There was a problem hiding this comment.
Please document this behavior change https://github.com/renovatebot/renovate/blob/main/docs/usage/opentelemetry.md
Signed-off-by: Aviv Guiser <avivguiser@gmail.com>
|
@secustor added docs |
Signed-off-by: Aviv Guiser <avivguiser@gmail.com>
HonkingGoose
suggested changes
Jun 11, 2024
Signed-off-by: Aviv Guiser <avivguiser@gmail.com>
secustor
requested changes
Jun 11, 2024
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
secustor
previously approved these changes
Jun 11, 2024
HonkingGoose
approved these changes
Jun 12, 2024
secustor
approved these changes
Jun 12, 2024
|
🎉 This PR is included in version 37.406.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
kosmoz
pushed a commit
to kosmoz/renovate
that referenced
this pull request
Jun 12, 2024
…space/version with env var (renovatebot#29583) Signed-off-by: Aviv Guiser <avivguiser@gmail.com> Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
add the option to overwrite the following otlp attrributes
OTEL_SERVICE_NAME
OTEL_SERVICE_NAMESPACE
OTEL_SERVICE_VERSION
if one of those values is not set in as env var then a default is used (same as always was)
Context
closes #28986
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: