Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(versioning/poetry): improve poetry2semver validation #29858

Merged
merged 1 commit into from
Jun 26, 2024
Merged

fix(versioning/poetry): improve poetry2semver validation #29858

merged 1 commit into from
Jun 26, 2024

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Jun 26, 2024 •
edited
Loading

Changes

Adds extra validation to poetry2semver function

Context

#29827

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice June 26, 2024 07:22
@rarkins rarkins enabled auto-merge June 26, 2024 07:22
viceice
viceice approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no test?

@rarkins rarkins added this pull request to the merge queue Jun 26, 2024
Merged via the queue into main with commit 98e089b Jun 26, 2024
37 checks passed
@rarkins rarkins deleted the fix/29827-harden-poetry-semver branch June 26, 2024 10:22
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.418.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot mentioned this pull request Jul 4, 2024
Merged
bryannaegele pushed a commit to bryannaegele/renovate that referenced this pull request Jul 8, 2024
@rarkins @bryannaegele
fix(versioning/poetry): improve poetry2semver validation (renovatebot…
9051a53 
…#29858)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rarkins @renovate-release @viceice