fix(manager/gradle): Add support for GCV 2.23.0 #29874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jamestoyer
changed the title
jamestoyer
changed the title
rarkins
approved these changes
Jun 26, 2024
|
🎉 This PR is included in version 37.419.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
viceice
reviewed
Jun 27, 2024
| @@ -9,7 +9,7 @@ import { isDependencyString, versionLikeSubstring } from '../utils'; | |||
| export const VERSIONS_PROPS = 'versions.props'; | |||
| export const VERSIONS_LOCK = 'versions.lock'; | |||
| export const LOCKFIlE_HEADER_TEXT = regEx( | |||
| /^# Run \.\/gradlew (?:--write-locks|writeVersionsLock) to regenerate this file/, | |||
| /^# Run \.\/gradlew (?:--write-locks|writeVersionsLock|writeVersionsLocks) to regenerate this file/, | |||
There was a problem hiding this comment.
Suggested change
| /^# Run \.\/gradlew (?:--write-locks|writeVersionsLock|writeVersionsLocks) to regenerate this file/, | |
| /^# Run \.\/gradlew (?:--write-locks|writeVersionsLocks?) to regenerate this file/, |
wouldn't this be simpler?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Update the Gradle Consistent Versions regex to support v2.23.0
Context
Version 2.23.0 of GCV subtly changed the
versions.lockheader, which means the regex no longer identifies it correct. Sadly, this wasn't called out in the changelog, but the change was made in palantir/gradle-consistent-versions#1194.Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: