Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(setup-node): fix steps order #29965

Merged
merged 1 commit into from
Jul 1, 2024
Merged

ci(setup-node): fix steps order #29965

merged 1 commit into from
Jul 1, 2024

Conversation

viceice
Copy link
Member

@viceice viceice commented Jul 1, 2024

Changes

Fix a step order bug. Currently PNPM_STORE is always empty, so never cached.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested review from rarkins and secustor July 1, 2024 13:28
@viceice viceice enabled auto-merge July 1, 2024 13:29
@viceice viceice added this pull request to the merge queue Jul 1, 2024
Merged via the queue into main with commit a0c447a Jul 1, 2024
38 checks passed
@viceice viceice deleted the ci/caching branch July 1, 2024 13:44
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.421.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

bryannaegele pushed a commit to bryannaegele/renovate that referenced this pull request Jul 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants