Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bunyan): drop optional deps #29982

Merged
merged 1 commit into from
Jul 2, 2024
Merged

fix(bunyan): drop optional deps #29982

merged 1 commit into from
Jul 2, 2024

Conversation

viceice
Copy link
Member

@viceice viceice commented Jul 2, 2024

Changes

  • Saves install time, especially on docker build (arm64) because of dtrace-provider native build.
  • moment is only use by bunyan cli, which we don't use.
  • mv is used for log file rotation, which we don't support.
  • safe-json-stringify is a third fallback, we hopefulle don't need it.

Context

https://github.com/trentm/node-bunyan/blob/5c2258ecb1d33ba34bd7fbd6167e33023dc06e40/lib/bunyan.js#L1218

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested a review from rarkins July 2, 2024 08:57
@viceice viceice added this pull request to the merge queue Jul 2, 2024
Merged via the queue into main with commit 161bc28 Jul 2, 2024
38 checks passed
@viceice viceice deleted the fix/drop-optional-deps branch July 2, 2024 10:52
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 37.421.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

bryannaegele pushed a commit to bryannaegele/renovate that referenced this pull request Jul 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants