-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gomod): Add gomodSkipVendor
postUpdateOption
#30025
feat(gomod): Add gomodSkipVendor
postUpdateOption
#30025
Conversation
gomodVendorSkip
postUpdateOption for gomodgomodVendorSkip
postUpdateOption
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a test for this skip case
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
6ebfe7a
to
c25ce26
Compare
bc80045
to
dc85766
Compare
gomodVendorSkip
postUpdateOptiongomodSkipVendor
postUpdateOption
I added a test that copies the |
…omod-postupdateoption-gomodvendorskip
Head branch was pushed to by a user without write access
I've fixed the test so it is now green. |
🎉 This issue has been resolved in version 37.428.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changes
This PR adds a postUpdateOption
gomodSkipVendor
which disables automatic vendoring functionality in thegomod
manager.Context
I'm creating this PR because I've had the issue described in:
Files that are removed by
go mod vendor
but are then restored in apostUpgradeTask
are not added to the final commit.After finding this comment in a discussion about go vendoring trouble I took a stab at adding the suggested option.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: