Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(git): enhance commit signing tests #30396

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

sisp
Copy link
Contributor

@sisp sisp commented Jul 26, 2024

Changes

I've factored out some test enhancements related to commit signing per @viceice's request (#29550 (comment)) from #29550 as a preparatory step for merging that PR.

Context

#29550 will add support for SSH-based commit signing in addition to existing GPG-based commit signing. For improved test robustness with two signing methods, I extended some existing tests there with more specific mocks and additional assertions. But to avoid mixing concerns and potential regressions in #29550, I've factored out the changes to GPG-related tests here.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

viceice
viceice previously approved these changes Jul 26, 2024
@viceice viceice added this pull request to the merge queue Jul 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 26, 2024
@rarkins rarkins added this pull request to the merge queue Jul 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 26, 2024
@viceice viceice added the ci:fulltest Run full test suite on all platforms label Jul 26, 2024
@viceice
Copy link
Member

viceice commented Jul 26, 2024

Test's are failing on macos

@sisp
Copy link
Contributor Author

sisp commented Jul 26, 2024

I had accidentally hardcoded /tmp/ as the temporary directory in the tests, which doesn't seem to work on macOS (and likely not on Windows either). I've fixed it in 1f0ce9a.

@rarkins rarkins added this pull request to the merge queue Jul 26, 2024
Merged via the queue into renovatebot:main with commit e5f4a1e Jul 26, 2024
51 checks passed
@sisp sisp deleted the test/refactor-commit-signing branch July 26, 2024 10:43
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 38.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci:fulltest Run full test suite on all platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants