refactor: move onboading repo lookup into dedicated function #30554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: LukasAuerbeck <17929465+LukasAuerbeck@users.noreply.github.com>
viceice
changed the title
viceice
reviewed
Aug 2, 2024
chore: move todo comment Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
viceice
approved these changes
Aug 2, 2024
|
🎉 This issue has been resolved in version 38.18.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Moves the onboarding repo lookup into a dedicated function to make it possible to have more complex logic in
getOnboardingConfigwithout mixing multiple things being done (iterating through the groups, looking for an existing renovate-config repo, ...)This change was initially part of #30350 and is moved to a separate PR.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: