fix(gradle): correct handling of heuristically matched dependency triples #33487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds special handling for an ambiguous parser match that occurs (only) when heuristically matching 3 string values in combination as
groupId
,artifactId
,version
.During parsing it is difficult to find out whether
groupId
,artifactId
andversion
are parts of exactly one complete dependency string or independent dependency strings. For example,groupId
could occur as a simple string or as one or more concatenated variables. The approach taken here is to first interpolate and then decide how to treat the values.Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
Test repo: https://github.com/renovate-demo/30234-renovate-tt-gradle-reproducer/pulls
Extracted dependencies (repository=renovate-demo/30234-renovate-tt-gradle-reproducer)