Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manager/haskell-cabal): Handle comments in Cabal file #33695

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

ysangkok
Copy link
Contributor

Changes

The Haskell Cabal file parser doesn't handle comments.

This is an issue, since files are parsed incorrectly, and generated patches are invalid.

I simply forgot to implement this, and there were no comments inside the build-depends section in the Cabal regression suite corpus.

Before this PR, an unindented comment would be able to terminate the block, which is incorrect.

Before this PR, commas within the comments would be used to split the dependency listing, which is also incorrect.

After this PR, those issues are resolved.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins added this pull request to the merge queue Jan 20, 2025
Merged via the queue into renovatebot:main with commit 2fe8305 Jan 20, 2025
39 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.117.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ysangkok ysangkok deleted the haskell-cabal-comments branch January 20, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants