fix(manager/haskell-cabal): Handle comments in Cabal file #33695
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The Haskell Cabal file parser doesn't handle comments.
This is an issue, since files are parsed incorrectly, and generated patches are invalid.
I simply forgot to implement this, and there were no comments inside the build-depends section in the Cabal regression suite corpus.
Before this PR, an unindented comment would be able to terminate the block, which is incorrect.
Before this PR, commas within the comments would be used to split the dependency listing, which is also incorrect.
After this PR, those issues are resolved.
Context
See this Renovate-generated commit, where a dependency is interpreted as including a following line, all the way up to it's final comma.
Issue reported by @wolfgangwalther in
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: