feat(manager/composer): support updates with minimal changes #34218
+128
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ste93cry
force-pushed
the
composer-updates-with-minimal-changes
branch
from
e68d34e to
6100dcd
Compare
rarkins
reviewed
Feb 14, 2025
rarkins
reviewed
Feb 14, 2025
viceice
reviewed
Feb 16, 2025
rarkins
requested changes
Feb 28, 2025
Comment on lines
+56
to
+61
| if ( | ||
| is.string(toolConstraint.constraint) && | ||
| api.intersects!(toolConstraint.constraint, '^2.7') | ||
| ) { | ||
| args += ' --minimal-changes'; | ||
| } |
There was a problem hiding this comment.
If api.intersects() can ever throw, it would be best to wrap this block in a try/catch and emit a logger.warn() if it ever throws (and then continue with default args)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I'm implementing a new function in the Composer package manager that, depending on the installed version, will append the
--minimal-changesoption to the command to update the dependencies. As the tool constraint can be either a single version or a range, like in the default case where the package manager version is not pinned explicitly, I had to expose theintersects()function of thesemverpackage, which allows checking whether the given constraint falls under the conditions for which the package manager supports the option.Context
Closes #34147
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: