Skip to content

feat(util): getEnv #35161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

feat(util): getEnv #35161

wants to merge 14 commits into from
+215 −105

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented Apr 3, 2025 •
edited
Loading

Changes

  • Added function getEnv() which returns the combination of process.env, customEnvVariables, and user env
  • Replaces most usage of process.env with getEnv()
  • Modified tests as necessary

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@RahulGautamSingh RahulGautamSingh marked this pull request as draft April 3, 2025 07:31
@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review April 3, 2025 10:33
@RahulGautamSingh RahulGautamSingh changed the title feat(util): getEnv [WIP] feat(util): getEnv Apr 3, 2025
viceice
viceice reviewed Apr 3, 2025
View reviewed changes
@RahulGautamSingh RahulGautamSingh marked this pull request as draft April 3, 2025 11:58
@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review April 3, 2025 15:05
@RahulGautamSingh
fix: lint
12b79b0
@RahulGautamSingh
fix: covergae
4a6180e 
replace istanbul ignore with v8 ignore
RahulGautamSingh
RahulGautamSingh commented Apr 3, 2025
View reviewed changes
Copy link
Collaborator Author

@RahulGautamSingh RahulGautamSingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need instructions for the following files.

@RahulGautamSingh @viceice
Update lib/workers/global/config/parse/codespaces.ts
44e1925 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@rarkins rarkins requested a review from viceice April 11, 2025 15:24
viceice
viceice reviewed Apr 14, 2025
View reviewed changes
rarkins
rarkins requested changes May 4, 2025
View reviewed changes
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs deconflicting

@RahulGautamSingh RahulGautamSingh requested a review from rarkins May 4, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viceice viceice Awaiting requested review from viceice

@rarkins rarkins Awaiting requested review from rarkins

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add getEnv() util and use in place of process.env
3 participants
@RahulGautamSingh @viceice @rarkins