Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: separate npm/yarn/pnpm/lerna package managers #4093

Closed
rarkins opened this issue Jul 15, 2019 · 1 comment
Closed

Idea: separate npm/yarn/pnpm/lerna package managers #4093

rarkins opened this issue Jul 15, 2019 · 1 comment
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code

Comments

@rarkins
Copy link
Collaborator

rarkins commented Jul 15, 2019

The existing "npm" manager in Renovate is really complex, partly due to its combination of npm/pnpm/yarn/lerna. I wonder if it would be feasible to separate them into separate package managers, albeit with a lot of shared code.

npm - if package-lock.json or npm-shrinkwrap.json are present, or no other managers are present (i.e. it's the default)
yarn - if yarn.lock is present. But not if there's lerna?
pnpm - look for pnpm's lock files
lerna - does it take precedence over yarn workspaces, or does yarn workspaces mean we can ignore lerna?

@rarkins rarkins added needs-requirements priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code labels Jul 15, 2019
@viceice
Copy link
Member

viceice commented Mar 3, 2020

superseeded by #5607

@viceice viceice closed this as completed Mar 3, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code
Projects
None yet
Development

No branches or pull requests

2 participants