Breaks with transformable properties

[danielctull]

At the moment transformable properties are being generated like as so @property (nonatomic, strong) idcolor; with no space between the type and identifier.

Two solutions to this seem to be:

• Change -objectAttributeType to return @"id " instead of @"id"
• Add a check in the template <$if Attribute.hasTransformableAttributeType$> <$endif$> to add the space

I'm not sure which it should be, I believe this is part of changes @robrix made, so I'm not sure what side affects changing the return from that method may cause.

[danielctull]

Either of those commits resolve this issue, I'm currently running with changing the template for safety. :)

[rentzsch]

Right you are, I intend to make transformable property class output smarter as detailed in #86 (comment)

[rentzsch]

Hmm, github can't seem to reopen issues atm, so I can't reopen #86, so your issue will serve as a handy placeholder for the v1.25 milestone :)

[smic]

This issue isn't fixed in 1.25, correct? As well as #86 ?

[rentzsch]

It's fixed, but I want to make it smarter.

[apparentsoft]

@rentzsch, I am still hit by the missing space on transformable attributes in 1.25.
At least with --template-var arc=true set.

[Soryu]

Same here, not using arc. Followed http://raptureinvenice.com/getting-started-with-mogenerator/

[rentzsch]

Are you sure you're using the latest templates? Please check against https://github.com/rentzsch/mogenerator/tree/master/templates

Apparently if you upgraded via homebrew you don't get upgraded templates by default.

[apparentsoft]

No, Wolf, I just downloaded the 1.25 from here and installed it.
From what I see, the template in master (the machine.h) doesn't have the extra space for transformables.

For now, I fixed my template manually, following changes in Daniel's following commit: https://github.com/danielctull/mogenerator/commit/c51c7442e015d89e156ddcea2a7420e772515221

In fact, this very issue has 2 commits from Daniel to address this issue but looks like you didn't merge his proposed changes.

[rentzsch]

Ah, I misunderstood the extent of the problem. Somehow I missed the broken codegen in test mule's ParentMO.myTransformableSansClassName. I thought this issue was more of a SHOULD, but now I understand it's a high-priority MUST.

[rentzsch]

Fixed in 1.26.