Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airgap uploads can require more memory than requested #1296

Open
laverya opened this issue Dec 2, 2020 · 1 comment
Open

Airgap uploads can require more memory than requested #1296

laverya opened this issue Dec 2, 2020 · 1 comment

Comments

@laverya
Copy link
Member

laverya commented Dec 2, 2020

Currently, we request 100Mi (with a limit of 500Mi) for kotsadm: https://github.com/replicatedhq/kots/blob/master/pkg/kotsadm/kotsadm_objects.go#L427-L436

In some situations (large images in airgap bundles in clusters under memory pressure) this results in kotsadm taking more than 100Mi of ram and being OOMkilled. This should be resolved somehow - either by setting the request equal to the limit or by improving the image decompress+push process.

@markpundsack
Copy link
Contributor

Is it being killed because it's exceeding the limit (500Mi), or that it's more than the request, and the cluster doesn't have enough memory?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants