Skip to content
This repository has been archived by the owner on Mar 24, 2023. It is now read-only.

Local upstreams do not work with plain yaml files #843

Closed
laverya opened this issue Feb 26, 2019 · 1 comment · Fixed by #844
Closed

Local upstreams do not work with plain yaml files #843

laverya opened this issue Feb 26, 2019 · 1 comment · Fixed by #844
Assignees

Comments

@laverya
Copy link
Member

laverya commented Feb 26, 2019

Expected behavior

ship init /path/to/yaml/files should work

Actual behavior

ship init /path/to/yaml/files breaks upon reaching the kustomize step with an error in debug.log: {"caller":"github.com/replicatedhq/ship/pkg/lifecycle/daemon/routes_navcycle_getstep.go","err":"initial kustomize run: write base kustomization: Base directory is empty","event":"preExecute.fail","level":"error","ts":"2019-02-25T21:38:10.984896Z"}

Information

  • Ship version: 0.34.0
  • Docker version: ...
  • Command line run: ship init ~/go/src/github.com/replicatedhq/test-charts/plain-k8s/

Steps to reproduce the behavior

  1. prepare a folder of kubernetes yaml locally
  2. run ship init with the absolute path to that folder
  3. observe failure upon reaching the kustomize step
@laverya
Copy link
Member Author

laverya commented Feb 26, 2019

This is related to the fact that go-getter uses symlinks for local files, and so instead of a folder base there is a symlink. Some of the libraries we use do not seem to appreciate this fact, and we should really be copying the files anyways in order to avoid modifying the source.

Unfortunately go-getter doesn't yet support copying directories (see hashicorp/go-getter#169) so we may have to handle that case ourselves for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant